Skip to content

fix: make changes for 1.2.36#2973

Merged
rxri merged 4 commits intomasterfrom
fix/components
Apr 22, 2024
Merged

fix: make changes for 1.2.36#2973
rxri merged 4 commits intomasterfrom
fix/components

Conversation

@rxri
Copy link
Member

@rxri rxri commented Apr 21, 2024

  • fixes IconComponent on 1.2.36 (tested on 1.2.13 also)
  • maps css for 1.2.36
  • sorted css map based on the name of class names
  • adds missing css for cards for 1.2.36
  • fixes styling on 1.2.36 (_getStyledClassName)
  • fixes config cmd: when provided value is empty, it should clear the field
  • fixes check for value, to not cause panic when it's empty
  • makes generated class names a little shorter (omits $padding[...] etc.)

Resolves #2974

@graphite-app graphite-app bot added core Issue or Pull Request about core functionality wrapper Issue or Pull Request about wrapper functionality labels Apr 21, 2024
@rxri rxri marked this pull request as draft April 21, 2024 12:03
@graphite-app
Copy link

graphite-app bot commented Apr 21, 2024

Graphite Automations

"Add `core` label on cli related changes" took an action on this PR • (04/21/24)

1 label was added to this PR based on ririxi's automation.

"Add `wrapper` label on wrapper related changes" took an action on this PR • (04/21/24)

1 label was added to this PR based on ririxi's automation.

@rxri rxri marked this pull request as ready for review April 21, 2024 12:29
@rxri rxri changed the title fix: make IconComponent usable again fix: make changes for 1.2.36 Apr 21, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes! Thanks!

@rxri rxri merged commit 83c3ad8 into master Apr 22, 2024
@rxri rxri deleted the fix/components branch April 22, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issue or Pull Request about core functionality wrapper Issue or Pull Request about wrapper functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants