Skip to content

fix(translator): force setting currentLyrics on cache hit#2983

Merged
afonsojramos merged 6 commits intomasterfrom
fix/lyrics-plus
Apr 30, 2024
Merged

fix(translator): force setting currentLyrics on cache hit#2983
afonsojramos merged 6 commits intomasterfrom
fix/lyrics-plus

Conversation

@rxri
Copy link
Member

@rxri rxri commented Apr 24, 2024

Fixes #2749
hopefully...

@graphite-app
Copy link

graphite-app bot commented Apr 24, 2024

Graphite Automations

"Add `custom app` label on custom app(s) related changes" took an action on this PR • (04/24/24)

1 label was added to this PR based on ririxi's automation.

@rxri rxri marked this pull request as draft April 24, 2024 23:38
@rxri rxri closed this Apr 25, 2024
@rxri rxri deleted the fix/lyrics-plus branch April 25, 2024 08:13
@rxri rxri restored the fix/lyrics-plus branch April 25, 2024 17:32
@rxri rxri changed the title fix(translator): translate lines one by one fix(translator): force setting currentLyrics on cache hit Apr 25, 2024
@rxri rxri reopened this Apr 25, 2024
@rxri rxri marked this pull request as ready for review April 25, 2024 17:34
@afonsojramos afonsojramos merged commit 1723d79 into master Apr 30, 2024
@afonsojramos afonsojramos deleted the fix/lyrics-plus branch April 30, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[custom apps] synced romanized lyrics sometimes not syncing with current song

4 participants