WIP: Sample of new handling for OneOf's #1856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88eced9 to
5feef52
Compare
|
Very excited to see this, having some sort of "which field is active"-enum (rather than looking for a non-null field) is very interesting to me right now. ❤️ |
c1ae1a9 to
d164bc4
Compare
d164bc4 to
69e06ea
Compare
69e06ea to
93cc75a
Compare
|
Nice! This is also super useful for logging, tracing and metrics |
swankjesse
reviewed
Jan 21, 2021
|
|
||
| data class Key<R>( | ||
| val tag: Int, | ||
| val adapter: ProtoAdapter<R>, |
Collaborator
There was a problem hiding this comment.
TODO: figure out if we can have cycles in declarations for these
Collaborator
There was a problem hiding this comment.
(the same problem we have for maps)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.