[Form] Use self-closing <input /> syntax again, reverting #47715
#53656
+44
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
Appveyor test failures seem to be unrelated. What’s the problem with license headers reported by fabbot? |
|
Can you please drop the code style commit? You can ignore fabbot's suggestions on these files as well as the license issues. |
9c9e965 to
8c92200
Compare
|
@xabbuh done |
xabbuh
approved these changes
Jan 29, 2024
|
Thank you @mpdude. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #47715 and puts the trailing slash back into
<input .../>markup in the form themes.The reasons are outlined in detail in #53649. Basically, the trailing slash in void elements like
<input>is not required in HTML 5, yet it is perfectly valid and compliant with specs.Writing markup that way is required to parse and process it with an XML parser, like
libxml2underlying all of the PHP DOM, XML etc. extensions.HTML 5 capable parser support has been added to PHP in php/php-src#12111 and will be available with PHP 8.4. So, we might want to remove the trailing slashes once Symfony requires at least PHP 8.4.