Skip to content

docs: ✏️ fix "handle submit" test and add expectation #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

Gpx
Copy link
Member

@Gpx Gpx commented Sep 19, 2018

What:

The "clicks submit button" test was not working because it was missing
handleClick. Also, it did not have any expectation which is weird for
a test.

Why:

I think having the test more "real-worldly" will make it easier to understand.

How:

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

The "clicks submit button" test was not working because it was missing
`handleClick`. Also, it did not have any expectation which is weird for
a test.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit b79104a into testing-library:master Sep 19, 2018
@Gpx Gpx deleted the click-button-test branch September 19, 2018 18:16
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants