Panic if AVX or FMA is missing #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our compilation on x86 enables fma and avx in target-feature. We should panic if the running CPU is actually missing the feature because otherwise the behavior is undefined and in practice we've seen segfaults. The panic will be translated to a Postgres error.
jgpruitt
previously approved these changes
Aug 7, 2024
Collaborator
Author
|
see #115 (comment) as well for more context |
adolsalamanca
previously approved these changes
Aug 7, 2024
thedodd
previously approved these changes
Aug 7, 2024
af2f179
fa97e06 to
8ecc2ba
Compare
8ecc2ba to
20c83d5
Compare
Vectors used with cosine distance are always normalized.
13a7cad to
0350cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our compilation on x86 enables fma and avx in target-feature. We should panic if the running CPU is actually missing the feature because otherwise the behavior is undefined and in practice we've seen segfaults.
The panic will be translated to a Postgres error.