Introduce pre-commit hooks template and fix cargo clippy issues #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: tjgreen42 <[email protected]>
syvb
approved these changes
Nov 7, 2024
cevian
approved these changes
Nov 7, 2024
Collaborator
cevian
left a comment
There was a problem hiding this comment.
LGTM, appreciate the separated commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the fixes were automatically generated by
cargo clippy --fixand do not need careful attention. The manual fixes that do need checking are in these two commits:Once this PR is merged, we can add
cargo clippyto the github checks. Also, devs should installpre-commitand runpre-commit installto pick up the new pre-commit hooks.Testing: existing unit tests