This repository was archived by the owner on Dec 2, 2025. It is now read-only.
Use controller-runtime's cluster instead of manager #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dc13a2 to
eeeeb95
Compare
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 76.21% 77.85% +1.64%
==========================================
Files 17 18 +1
Lines 412 429 +17
==========================================
+ Hits 314 334 +20
+ Misses 87 82 -5
- Partials 11 13 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hegel originally integrated with Kubernetes by using a tink repo defined client that handled the client construction for a service. The implementation leveraged the controller-runtime manager data structure that comes with a lot more than whats needed by a service. Consequently, it needs to mute features such as metrics endpoints etc. This change switches to the cluster object which is much lighter weight and focus' on representing a cluster (with caching of obects) instead of a fully fledged controller manager. Signed-off-by: Chris Doherty <[email protected]>
eeeeb95 to
4bda0aa
Compare
jacobweinstock
approved these changes
May 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hegel originally integrated with Kubernetes by using a tink repo defined client that handled the client construction for a service. The implementation leveraged the controller-runtime manager data structure that comes with a lot more than whats needed by a service. Consequently, it needs to mute features such as metrics endpoints etc.
This change switches to the cluster object which is much lighter weight and focus' on representing a cluster (with caching of obects) instead of a fully fledged controller manager.
Other notes
go mod tidycleaned up a bunch of dependencies probably left from the Go v1.20 update.Issues
Closes #195