Send 'sub' push notifications when user joins a group. #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to notify group members of a new subscription. Presently, this is only available in p2p topic.
or-else
approved these changes
Jun 2, 2021
Contributor
There was a problem hiding this comment.
There was a bug in Android which also independently caused 'Not found' group members:
tinode/tindroid@055f8b5
Specifically changes like this fixed it:
if (isP2PType()) {
mTinode.updateUser(getName(), mDesc);
}It probably exists in iOS too.
server/topic.go
Outdated
| } | ||
| } | ||
| } else if t.cat == types.TopicCatGrp { | ||
| if pushRcpt := t.pushForGroupSub(asUid, types.TimeNow()); pushRcpt != nil { |
Contributor
There was a problem hiding this comment.
Please also check if sreg.pkt.Sub.Newsub is true. Otherwise pushes will be sent on all permission changes.
server/topic.go
Outdated
| } | ||
|
|
||
| // Prepares payload to be delivered to a mobile device as a push notification in response to a new subscription in a p2p topic. | ||
| func (t *Topic) pushForSub(fromUid, toUid types.Uid, want, given types.AccessMode, now time.Time) *push.Receipt { |
Contributor
Author
Thanks. I'll make comparable changes in iOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to notify group members of a new subscription.
Presently, this is only available in p2p topic.
This is the reason why new subscriptions show up as unknown (id) in group chats in certain cases.