fix: hash in table of contents #676
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crozzers
reviewed
Jan 19, 2026
test/test_markdown2.py
Outdated
| self.assertEqual(expected_toc_html, md.convert(html).toc_html) | ||
| test_toc_with_persistent_object.tags = ["toc", "issue208"] | ||
|
|
||
| def test_toc_with_inline_code(self): |
Contributor
There was a problem hiding this comment.
Test cases like this are usually implemented in test/tm-cases. You put the markdown in tm-cases/my_testcase.text, the expected HTML in tm-cases/my_testcase.html and any options passed to the Markown class in tm-cases/my_testcase.opts. Can also put any tags in a .tags file.
I think the only tests not implemented like that are ReDoS tests.
For consistency in testcase reporting and for what devs expect, probably best to follow that format
b40a342 to
22a82ca
Compare
22a82ca to
960ae34
Compare
Contributor
|
LGTM assuming the tests pass. @nicholasserra? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the regex in
_h_tag_subsuch that it doesn't keep matching the entire line if there is no whitespace.Closes: #675