add HTML5 validation of docs pages to the build #9396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Not opposed to it, but I'm curious how fucked the docs currently are to see if this is feasible/maintainable 😆. |
Collaborator
Author
|
Well, the Travis build runs now, so you can take a look-see. |
Collaborator
Author
|
It's mostly the |
Collaborator
Author
|
Validity fixes moved to #9399. |
Collaborator
Author
|
@mdo Only remaining errors are ARIA stuff and |
use `data:` URL of empty invalid PNG: src="data:image/png;base64,"
…ia-labelledby validates
Collaborator
Author
|
@mdo The docs fully validate now! Should be good to merge at your leisure/command. |
mdo
added a commit
that referenced
this pull request
Aug 13, 2013
add HTML5 validation of docs pages to the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works,
but shouldn't be merged until the docs are fixed to actually pass validation.and the docs now validate!This PR is also a feeler for whether @mdo would be interested in this.
Note:
grunt-html-validationis slightly broken in that it doesn't fail the build when validation fails; but it works fine otherwise.