Skip to content

Conversation

@chasestarr
Copy link
Collaborator

Description

This major release of baseui includes no runtime changes to the library, but does include breaking typescript updates. If your application does not use TS there should be no changes.

Many typescript types have been updated to drop the T suffix so PropsT is now Props in most instances. We've included backwards compatible aliases for t-suffixed types and those will be removed in a future major release. The main backwards incompatible change of note is when using the styled function and provide generic parameters. The params order is reversed from the previous release to align closer with styletron.

// v11
const X = styled<{}, 'div'>('div', {})
// v12
const X = styled<'div', {}>('div', {})

Please file issues if any type errors are found.

Scope

Major: Breaking change

converts baseui codebase to typescript
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c2e3385:

Sandbox Source
Basic usage Configuration

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 20, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2e3385
Status: ✅  Deploy successful!
Preview URL: https://cb703165.baseweb.pages.dev
Branch Preview URL: https://chasestarr-patch-36.baseweb.pages.dev

View logs

@chasestarr chasestarr merged commit 76e4c0c into master Jul 21, 2022
@chasestarr chasestarr deleted the chasestarr-patch-36 branch July 21, 2022 21:42
andriuss pushed a commit to andriuss/baseweb that referenced this pull request Aug 2, 2022
converts baseui codebase to typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants