This repository was archived by the owner on Mar 5, 2024. It is now read-only.
Allow kiam-agent to not remove rules on the host #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where kiam should not remove the iptables rules at shutdown. This avoids cases where metadata from the host will leak when kiam is reprovisioning, has crashed, etc, which causes any AWS SDK to cache and try to use host credentials for hours on end.
pingles
approved these changes
Jun 10, 2019
Contributor
pingles
left a comment
There was a problem hiding this comment.
Love it, thanks for the contribution!
I'll try and release tomorrow unless someone else from @uswitch/cloud picks it up before me.
|
Does this fix #202? |
Contributor
Author
|
Yes, it looks like it would fix that issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where kiam should not remove the iptables rules at
shutdown. This avoids cases where metadata from the host will leak
when kiam is reprovisioning, has crashed, etc, which causes any AWS
SDK to cache and try to use host credentials for hours on end.