[CI] upgrade dpctl/dpnp versions#2414
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
This PR must wait until 2025.1 is available on apt for Linux. Then corrections to the codebase must be completed |
abefd21 to
7d88e6e
Compare
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
| return X | ||
|
|
||
| _transform = support_input_format(_sklearn_KMeans._transform) | ||
| transform = support_input_format(_sklearn_KMeans.transform) |
There was a problem hiding this comment.
Was this meant to replace the line before?
There was a problem hiding this comment.
Unfortunately no fit_transform, allowing for the second valdiation to be removed. We reuse _transform in our fit_transform implementation too, so I can't remove it there, but I need make transform work. I couldn't swap in a dispatch because we don't accelerate anything there with oneDAL in either case. Direct use of KMeans.transform using dpctl 0.18 is likely to be extremely slow. In general this is because its not a high-prority method, which we technically support but in a very bad way/ without benchmarking.
There was a problem hiding this comment.
Perhaps that could be left as a comment for when it comes the time to refactor again.
ahuber21
left a comment
There was a problem hiding this comment.
Approving, but subject to green CI (GH actions & pre-commit). I'm okay with ugly solutions for broken tests as long as we follow up. Let's organize that offline.
|
/intelci: run |
david-cortes-intel
left a comment
There was a problem hiding this comment.
LGTM, pending CI results.
Description
This upgrades the version of dpnp and dpctl based off the recent release. This will notably add array_api support to dpnp.
This PR does the following:
support_sycl_format) to move sycl data to cpu beforevalidate_datais called, as the__array__attribute has become blockedto_dpnpfunction to use now that the previous method has become blocked for data zero copy of dpnp data, use it instead.kneighbors_graphsupport_input_formatorsupport_sycl_formatin order to guarantee sycl support with and without array api support (because of the blocking of np.array)EmpiricalCovariance.fitwhich should occur after dispatching.PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).