MAINT: Remove separate daal4py docs#2429
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/intelci: run |
|
Error in azure pipelines is unrelated to the changes here: Error in internal CI is also unrelated, will try to re-run to see if it's fixed. |
|
/intelci: run |
Yeah, this is quite worrisome as its occurring in lots of PRs (including some of mine). I don't think you need to waste the effort rolling the dice in getting it to pass. I was sort of hoping that we could get someone on the team to attack kMeans with asan... |
icfaust
left a comment
There was a problem hiding this comment.
thanks for the 3k+ line reduction! Just a small request, otherwise good to go.
| - svm/tests/test_svm.py::test_custom_kernel_not_array_input[SVR] | ||
|
|
||
| # test_non_uniform_strategies fails due to differences in handling of vacuous clusters after update | ||
| # See https://github.com/IntelPython/daal4py/issues/69 |
There was a problem hiding this comment.
wow, I've been through deselected tests hundreds of times and never paid attention to this. Crazy that 1 we still have references to IntelPython here, and 2 we haven't properly closed that issue.
| project_urls = { | ||
| "Bug Tracker": "https://github.com/uxlfoundation/scikit-learn-intelex", | ||
| "Documentation": "https://intelpython.github.io/daal4py/", | ||
| "Documentation": "https://uxlfoundation.github.io/scikit-learn-intelex/", |
There was a problem hiding this comment.
Hate to be a bother: could you also change the other project urls? It looks like for example that the source code line should be https://github.com/uxlfoundation/scikit-learn-intelex instead of https://github.com/uxlfoundation/scikit-learn-intelex/daal4py and that bug tracker should probably link to /issues. You can say 'not in scope of the PR' if you really don't want to.
There was a problem hiding this comment.
Updated.
Description
After previous PR: #2395
All the technical documentation about daal4py has been merged into the sklearnex docs, and doc sections about the relevant parts of daal4py have been added.
Thus, there's no further need to keep a separate documentation system for daal4py, the more so since it isn't used or deployed anywhere.
This PR removes those docs and all remaining references to them.
Note that this also removes a file with third-party licenses which is currently being bundled by the packaging scripts, so updates elsewhere might be required afterwards. All of the contents in that file are already present in the same third-party licenses under sklearnex so nothing is being missed.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.