Skip to content

Fixes for sklearn 1.7 pre-release support (backport #2451)#2528

Merged
napetrov merged 1 commit into
rls/2025.5.0-rlsfrom
mergify/bp/rls/2025.5.0-rls/pr-2451
Jun 10, 2025
Merged

Fixes for sklearn 1.7 pre-release support (backport #2451)#2528
napetrov merged 1 commit into
rls/2025.5.0-rlsfrom
mergify/bp/rls/2025.5.0-rls/pr-2451

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jun 10, 2025

Description

Fixes for sklearn 1.7 pre-release support:

  • Remove usage of deleted sklearn.utils._joblib module in pairwise distances
  • Change internal TSNE parameter name to max_iter for sklearn>=1.7
  • Fix onedal.utils._array_api._is_numpy_namespace to support new sklearn's xp name
  • Temporary fix probabilities not in [0, 1] interval computed by ensemble models on sklearnex side (sklearn started enforcing upper interval border in estimator check).

Note: this PR fixes critical failures, there are still sklearnex and sklearn test failures.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

N/A.


This is an automatic backport of pull request #2451 done by [Mergify](https://mergify.com).

* Fixes for sklearn 1.7 pre-release support

* Fix ensemble probabilities interval

* Change scaling method to `clip`

---------

Co-authored-by: icfaust <icfaust@gmail.com>
(cherry picked from commit 95c73bd)
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
azure 79.77% <100.00%> (+0.03%) ⬆️
github ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
onedal/ensemble/forest.py 73.49% <100.00%> (+0.09%) ⬆️
onedal/utils/_array_api.py 62.50% <100.00%> (ø)

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@napetrov napetrov merged commit 0e56163 into rls/2025.5.0-rls Jun 10, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants