[Fix] [Array API] Raise AttributeError for non-homogen tables in __sycl_usm_array_interface__ to comply with Python interop expectations#2640
Merged
KateBlueSky merged 3 commits intoAug 4, 2025
Conversation
Contributor
|
@KateBlueSky Good catch! Does this mean that csr_tables would fail |
Contributor
Author
yes, it would throw a runtime error in the original code. |
icfaust
approved these changes
Jul 31, 2025
Contributor
|
/intelci: run |
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
/intelci: run |
1 similar comment
Contributor
Author
|
/intelci: run |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise AttributeError for non-homogen tables in sycl_usm_array_interface to comply with Python interop expectations
This PR updates the behavior of the sycl_usm_array_interface property for oneDAL table objects to improve compatibility with Python SYCL-aware libraries (e.g. dpctl, dpnp, numba-dpex).
Previously, the property handler used report_problem_to_sua_iface(": only homogen tables are supported");
to signal unsupported table types (e.g., sparse or non-homogen tables). However, this results in a non attribute related error being raised, which breaks compatibility with Python’s hasattr() behavior, and can surface as runtime errors in downstream libraries that probe for SYCL USM compatibility.
The fix aligns with Python data protocol conventions (e.g., array_interface, cuda_array_interface), which require AttributeError to signal absence.
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing