Skip to content

middlewares: limit process.env to inferred usage #33186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 8 commits into from
Jan 12, 2022
Merged

middlewares: limit process.env to inferred usage #33186

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e8a960
middlewares: limit `process.env` to inferred usage
Schniz Jan 11, 2022
39c3207
Merge branch 'canary' into limit-process-env-to-middleware-env-output
Schniz Jan 11, 2022
4dbec5d
make middleware plugin aware of environment variables in server compo…
Schniz Jan 12, 2022
bdd9a17
use constant
Schniz Jan 12, 2022
9b75923
Check runtimes for both cases for consistency
Schniz Jan 12, 2022
577a44c
lint fix
Schniz Jan 12, 2022
1bd0e19
Merge branch 'canary' into limit-process-env-to-middleware-env-output
kodiakhq[bot] Jan 12, 2022
31d50be
Merge branch 'canary' into limit-process-env-to-middleware-env-output
kodiakhq[bot] Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use constant
  • Loading branch information
@Schniz
Schniz committed Jan 12, 2022
commit bdd9a1700a4d241faaf457301693dd88188162e5
5 changes: 3 additions & 2 deletions packages/next/build/webpack/plugins/middleware-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
MIDDLEWARE_BUILD_MANIFEST,
MIDDLEWARE_REACT_LOADABLE_MANIFEST,
MIDDLEWARE_RUNTIME_WEBPACK,
MIDDLEWARE_SSR_RUNTIME_WEBPACK,
} from '../../../shared/lib/constants'
import { MIDDLEWARE_ROUTE } from '../../../lib/constants'
import { nonNullable } from '../../../lib/non-nullable'
Expand Down Expand Up @@ -142,8 +143,8 @@ export default class MiddlewarePlugin {

for (const [name, info] of compilation.entries) {
if (
name.match(MIDDLEWARE_ROUTE) ||
info.options.runtime === 'middleware-ssr-runtime'
info.options.runtime === MIDDLEWARE_SSR_RUNTIME_WEBPACK ||
name.match(MIDDLEWARE_ROUTE)
) {
const middlewareEntries = new Set<webpack5.Module>()
const env = new Set<string>()
Expand Down