Skip to content

feat(cli): support examples without package.json #37910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 7 commits into from
Jun 23, 2022
Merged

feat(cli): support examples without package.json #37910

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
283763d
fix: support examples without package.json in CLI
balazsorban44 Jun 22, 2022
dd77d65
add test
balazsorban44 Jun 22, 2022
8cfabb4
remove `.only`
balazsorban44 Jun 22, 2022
18a7a85
fix
balazsorban44 Jun 22, 2022
adc4778
check for `package.json` locally
balazsorban44 Jun 23, 2022
5e75e86
check if `package.json` exists only once
balazsorban44 Jun 23, 2022
f4af2a4
Merge branch 'canary' into fix/cli-support-example-without-package-json
ijjk Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check for package.json locally
  • Loading branch information
@balazsorban44
balazsorban44 committed Jun 23, 2022
commit adc4778a77f882257340659fe6ffadb7d0cb2213
9 changes: 5 additions & 4 deletions packages/create-next-app/create-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ export async function createApp({

process.chdir(root)

const hasPackageJSON = await existsInRepo(`${example}/package.json`)

if (example) {
/**
* If an example repository is provided, clone it.
Expand Down Expand Up @@ -187,7 +185,8 @@ export async function createApp({
)
}

if (hasPackageJSON) {
const packageJsonPath = path.join(root, 'package.json')
if (fs.existsSync(packageJsonPath)) {
console.log('Installing packages. This might take a couple of minutes.')
console.log()

Expand Down Expand Up @@ -310,7 +309,9 @@ export async function createApp({
}

console.log(`${chalk.green('Success!')} Created ${appName} at ${appPath}`)
if (hasPackageJSON) {

const packageJsonPath = path.join(root, 'package.json')
if (fs.existsSync(packageJsonPath)) {
console.log('Inside that directory, you can run several commands:')
console.log()
console.log(chalk.cyan(` ${packageManager} ${useYarn ? '' : 'run '}dev`))
Expand Down