-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add GitHub Actions environment variable as default passthrough #10740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allowing those variables to pass through by default would make using turborepo with GitHub Actions more seamless. For example, NPM relies on `GITHUB_ACTIONS` for automatic provenance detection. (see https://github.com/npm/cli/blob/5d82d0b4a4bd1424031fb68b4df740c1bbe5b172/lib/utils/oidc.js#L11) By obfuscating the variable, it can be pretty confusing for users of both turborepo and npm as to why the provenance generation stopped working (don't ask me how I know).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@louis-bompart is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
A bit more esoteric but related to the same initial problem (npm publish with provenance fails if executed through turborepo), I think it might be good to add |
https://coveord.atlassian.net/browse/KIT-4720 and + some for Quantic, just playin' safe. Fix-it-twice maybe in vercel/turborepo#10740
https://coveord.atlassian.net/browse/KIT-4720 and + some for Quantic, just playin' safe. Fix-it-twice maybe in vercel/turborepo#10740
https://coveord.atlassian.net/browse/KIT-4720 and + some for Quantic, just playin' safe. Fix-it-twice maybe in vercel/turborepo#10740
anthonyshew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. 👍
|
@anthonyshew: That would be amazing if we could get this merged. I believe this is a blocker for adoption, or at least, a friction, as most nice CI features aren't working by default when using Turborepo because the |
|
Failures for examples are not related, so merging. |
### Description #10740 broke our integration tests because they now are aware that they are in a GitHub Action. This unsets the offending environment variable so that the logs are restored to how they were before. ### Testing Instructions CI
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [turbo](https://turborepo.com) ([source](https://github.com/vercel/turborepo)) | [`2.6.2` -> `2.6.3`](https://renovatebot.com/diffs/npm/turbo/2.6.2/2.6.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo (turbo)</summary> ### [`v2.6.3`](https://github.com/vercel/turborepo/releases/tag/v2.6.3): Turborepo v2.6.3 [Compare Source](vercel/turborepo@v2.6.2...v2.6.3) <!-- Release notes generated using configuration in .github/release.yml at v2.6.3 --> #### What's Changed ##### turbo-ignore - fix: Command injection in `turbo-ignore` by [@​pyrytakala](https://github.com/pyrytakala) in [#​11154](vercel/turborepo#11154) ##### Examples - examples(security): Upgrade `Next.js` versions by [@​2qp](https://github.com/2qp) in [#​11195](vercel/turborepo#11195) ##### Changelog - fix: Prevent vt100 TUI crash during column wrap by [@​neel3o115](https://github.com/neel3o115) in [#​11170](vercel/turborepo#11170) - feat: Add GitHub Actions environment variable as default passthrough by [@​louis-bompart](https://github.com/louis-bompart) in [#​10740](vercel/turborepo#10740) - docs: Updating READMEs by [@​anthonyshew](https://github.com/anthonyshew) in [#​11190](vercel/turborepo#11190) - fix: Handle pidlock AlreadyOwned without failing init in LSP by [@​AryanBagade](https://github.com/AryanBagade) in [#​10831](vercel/turborepo#10831) - ci: Fix integration test logging style by [@​anthonyshew](https://github.com/anthonyshew) in [#​11194](vercel/turborepo#11194) - fix: Normalize config dir env vars to absolute by [@​Vansh0204](https://github.com/Vansh0204) in [#​11146](vercel/turborepo#11146) - fix(vercel-api): Add `VIEWER_FOR_PLUS` and `SECURITY` role variants by [@​amondnet](https://github.com/amondnet) in [#​11169](vercel/turborepo#11169) #### New Contributors - [@​neel3o115](https://github.com/neel3o115) made their first contribution in [#​11170](vercel/turborepo#11170) - [@​louis-bompart](https://github.com/louis-bompart) made their first contribution in [#​10740](vercel/turborepo#10740) - [@​AryanBagade](https://github.com/AryanBagade) made their first contribution in [#​10831](vercel/turborepo#10831) - [@​Vansh0204](https://github.com/Vansh0204) made their first contribution in [#​11146](vercel/turborepo#11146) - [@​amondnet](https://github.com/amondnet) made their first contribution in [#​11169](vercel/turborepo#11169) - [@​pyrytakala](https://github.com/pyrytakala) made their first contribution in [#​11154](vercel/turborepo#11154) **Full Changelog**: <vercel/turborepo@v2.6.2...v2.6.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNC4yIiwidXBkYXRlZEluVmVyIjoiNDIuMTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/66 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Description
Allowing those variables to pass through by default would make using turborepo with GitHub Actions more seamless.
For example, NPM relies on
GITHUB_ACTIONSfor automatic provenance detection. (see https://github.com/npm/cli/blob/5d82d0b4a4bd1424031fb68b4df740c1bbe5b172/lib/utils/oidc.js#L11) By obfuscating the variable, it can be pretty confusing for users of both turborepo and npm as to why the provenance generation stopped working (don't ask me how I know).Testing Instructions
(I'll be honest, I did not test it, but essentially follow the footstep of #9235, just with some GitHub sprinkles on top.)
Fixes #11140