Skip to content

Conversation

@louis-bompart
Copy link
Contributor

@louis-bompart louis-bompart commented Aug 6, 2025

Description

Allowing those variables to pass through by default would make using turborepo with GitHub Actions more seamless.

For example, NPM relies on GITHUB_ACTIONS for automatic provenance detection. (see https://github.com/npm/cli/blob/5d82d0b4a4bd1424031fb68b4df740c1bbe5b172/lib/utils/oidc.js#L11) By obfuscating the variable, it can be pretty confusing for users of both turborepo and npm as to why the provenance generation stopped working (don't ask me how I know).

Testing Instructions

(I'll be honest, I did not test it, but essentially follow the footstep of #9235, just with some GitHub sprinkles on top.)

Fixes #11140

Allowing those variables to pass through by default would make using turborepo with GitHub Actions more seamless.

For example, NPM relies on `GITHUB_ACTIONS` for automatic provenance detection. (see https://github.com/npm/cli/blob/5d82d0b4a4bd1424031fb68b4df740c1bbe5b172/lib/utils/oidc.js#L11)
By obfuscating the variable, it can be pretty confusing for users of both turborepo and npm as to why the provenance generation stopped working (don't ask me how I know).
@vercel
Copy link
Contributor

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
examples-basic-web Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-designsystem-docs Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-gatsby-web Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-kitchensink-blog Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-nonmonorepo Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-svelte-web Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-tailwind-web Ready Ready Preview Comment Dec 3, 2025 8:15pm
examples-vite-web Ready Ready Preview Comment Dec 3, 2025 8:15pm
turbo-site Ready Ready Preview Comment Dec 3, 2025 8:15pm

@vercel
Copy link
Contributor

vercel bot commented Aug 6, 2025

@louis-bompart is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@louis-bompart
Copy link
Contributor Author

A bit more esoteric but related to the same initial problem (npm publish with provenance fails if executed through turborepo), I think it might be good to add ACTIONS_ID_TOKEN_REQUEST_TOKEN and ACTIONS_ID_TOKEN_REQUEST_URL to the passthru which is used for OIDC (and by extension npm publishing w/ provenance) with GitHub Actions:
https://docs.github.com/en/actions/reference/security/oidc

github-merge-queue bot pushed a commit to coveo/ui-kit that referenced this pull request Aug 6, 2025
github-merge-queue bot pushed a commit to coveo/ui-kit that referenced this pull request Aug 6, 2025
github-merge-queue bot pushed a commit to coveo/ui-kit that referenced this pull request Aug 7, 2025
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 👍

@charpeni
Copy link
Contributor

@anthonyshew: That would be amazing if we could get this merged. I believe this is a blocker for adoption, or at least, a friction, as most nice CI features aren't working by default when using Turborepo because the GITHUB_ACTIONS environment variable isn't exposed. E.g., GitHub Annotations from test runners.

@anthonyshew anthonyshew changed the title feat: add GitHub Actions environment variable as default passthru feat: Add GitHub Actions environment variable as default passthrough Dec 3, 2025
@anthonyshew
Copy link
Contributor

Failures for examples are not related, so merging.

@anthonyshew anthonyshew merged commit 43d7ffc into vercel:main Dec 3, 2025
95 of 100 checks passed
anthonyshew added a commit that referenced this pull request Dec 3, 2025
### Description

#10740 broke our integration tests because they now are aware that they
are in a GitHub Action. This unsets the offending environment variable
so that the logs are restored to how they were before.

### Testing Instructions

CI
ch4og pushed a commit to csmplay/mapban that referenced this pull request Dec 4, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [turbo](https://turborepo.com) ([source](https://github.com/vercel/turborepo)) | [`2.6.2` -> `2.6.3`](https://renovatebot.com/diffs/npm/turbo/2.6.2/2.6.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.6.2/2.6.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>vercel/turborepo (turbo)</summary>

### [`v2.6.3`](https://github.com/vercel/turborepo/releases/tag/v2.6.3): Turborepo v2.6.3

[Compare Source](vercel/turborepo@v2.6.2...v2.6.3)

<!-- Release notes generated using configuration in .github/release.yml at v2.6.3 -->

#### What's Changed

##### turbo-ignore

- fix: Command injection in `turbo-ignore` by [@&#8203;pyrytakala](https://github.com/pyrytakala) in [#&#8203;11154](vercel/turborepo#11154)

##### Examples

- examples(security): Upgrade `Next.js` versions by [@&#8203;2qp](https://github.com/2qp) in [#&#8203;11195](vercel/turborepo#11195)

##### Changelog

- fix: Prevent vt100 TUI crash during column wrap by [@&#8203;neel3o115](https://github.com/neel3o115) in [#&#8203;11170](vercel/turborepo#11170)
- feat: Add GitHub Actions environment variable as default passthrough by [@&#8203;louis-bompart](https://github.com/louis-bompart) in [#&#8203;10740](vercel/turborepo#10740)
- docs: Updating READMEs by [@&#8203;anthonyshew](https://github.com/anthonyshew) in [#&#8203;11190](vercel/turborepo#11190)
- fix: Handle pidlock AlreadyOwned without failing init in LSP by [@&#8203;AryanBagade](https://github.com/AryanBagade) in [#&#8203;10831](vercel/turborepo#10831)
- ci: Fix integration test logging style by [@&#8203;anthonyshew](https://github.com/anthonyshew) in [#&#8203;11194](vercel/turborepo#11194)
- fix: Normalize config dir env vars to absolute by [@&#8203;Vansh0204](https://github.com/Vansh0204) in [#&#8203;11146](vercel/turborepo#11146)
- fix(vercel-api): Add `VIEWER_FOR_PLUS` and `SECURITY` role variants by [@&#8203;amondnet](https://github.com/amondnet) in [#&#8203;11169](vercel/turborepo#11169)

#### New Contributors

- [@&#8203;neel3o115](https://github.com/neel3o115) made their first contribution in [#&#8203;11170](vercel/turborepo#11170)
- [@&#8203;louis-bompart](https://github.com/louis-bompart) made their first contribution in [#&#8203;10740](vercel/turborepo#10740)
- [@&#8203;AryanBagade](https://github.com/AryanBagade) made their first contribution in [#&#8203;10831](vercel/turborepo#10831)
- [@&#8203;Vansh0204](https://github.com/Vansh0204) made their first contribution in [#&#8203;11146](vercel/turborepo#11146)
- [@&#8203;amondnet](https://github.com/amondnet) made their first contribution in [#&#8203;11169](vercel/turborepo#11169)
- [@&#8203;pyrytakala](https://github.com/pyrytakala) made their first contribution in [#&#8203;11154](vercel/turborepo#11154)

**Full Changelog**: <vercel/turborepo@v2.6.2...v2.6.3>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNC4yIiwidXBkYXRlZEluVmVyIjoiNDIuMTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/66
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
@vercel vercel bot mentioned this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants