fix: Correct version mismatch causing noUpdateNotifier to fail #11133

DevaanshKathuria · 2025-11-18T10:26:07Z

This pull request fixes a bug where setting "noUpdateNotifier": true in turbo.json did not suppress update notifications.
Turbo continued printing out-of-date version warnings regardless of the flag’s value.
What was happening
Even when users explicitly disabled update notifications using:
{ "noUpdateNotifier": true }
Turbo still displayed upgrade messages when the installed version was behind the latest available version.
This violated the expected behavior described in Issue #10940.
What this PR does:

Ensures that when noUpdateNotifier is set to true, Turbo skips the update-notifier check entirely.
Prevents unnecessary noise in CI pipelines and automated scripts.
Restores expected behavior and aligns with Turbo’s configuration contract.

How I verified the fix:
Added "noUpdateNotifier": true to turbo.json.
Ran Turbo using an intentionally outdated version.
Confirmed that no update notification was printed.
Verified that notifications still appear when the flag is not set.

Linked Issue
Fixes: #10940

_{CLOSES TURBO-4878}

vercel · 2025-11-18T10:26:16Z

@DevaanshKathuria is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

crates/turborepo-lib/src/shim/local_turbo_config.rs

crates/turborepo-updater/src/lib.rs

Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>

DevaanshKathuria · 2025-11-21T13:56:02Z

Hey @tknickman, I hope you're doing well. Whenever you get a moment, could you please take a look at the PR and share your feedback on whether it’s ready to be merged? Thanks!

DevaanshKathuria · 2025-11-30T07:06:22Z

Hi @tknickman! Just checking in on the PR I submitted a while ago.
Whenever you get a moment, please take a look. Thanks!

DevaanshKathuria · 2025-12-02T04:05:06Z

Hey @anthonyshew! If you get a little time, could you please review this PR for me?
My assigned reviewer seems busy, so any help would be great. Thanks a lot!

crates/turborepo-lib/src/shim/local_turbo_config.rs

crates/turborepo-lib/src/config/mod.rs

crates/turborepo-lib/src/shim/mod.rs

anthonyshew

I left a few comments in the file changes, and one more to add.

Take a look at these codepointers:

crates/turborepo-lib/src/shim/mod.rs:319 - checks !config.no_update_notifier()
crates/turborepo-lib/src/shim/mod.rs:344 - passes config.no_update_notifier.unwrap_or(false) to function
crates/turborepo-updater/src/lib.rs:109 - checks the same value again

This looks redundant, like we're checking twice.

You can either:

Remove the parameter from display_update_check() since the caller already guards the call
Or remove the outer guard and let the updater own all skip logic

Thanks for taking the time to fix this! I think we will be able to merge after these are fixed.

Co-authored-by: Anthony Shew <[email protected]>

…nfig/mod.rs

…shKathuria/turborepo into noUpdateNotifier-resolved

DevaanshKathuria · 2025-12-06T07:06:34Z

Hey @anthonyshew, I've made all the required changes. Please review them and let me know if any further changes are needed.

anthonyshew

The PR now has no functional changes.

DevaanshKathuria · 2025-12-06T13:33:38Z

@anthonyshew, I’m really sorry that I didn’t compare the latest commit with the original code. I can try the other option. How about I remove the outer guard so the updater can use its own logic, as you suggested?

DevaanshKathuria · 2025-12-12T19:27:58Z

Hi @anthonyshew! Just checking in on the PR.
Whenever you get a moment, please take a look. Thanks!

anthonyshew · 2025-12-20T18:35:26Z

#10941 was already working on this but I'll pick this work back up from this one.

vercel · 2025-12-20T19:00:05Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
examples-basic-web	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-designsystem-docs	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-gatsby-web	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-kitchensink-blog	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-nonmonorepo	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-svelte-web	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-tailwind-web	Ready	Preview, Comment	Dec 20, 2025 7:01pm
examples-vite-web	Ready	Preview, Comment	Dec 20, 2025 7:01pm
turbo-site	Ready	Preview, Comment	Dec 20, 2025 7:01pm

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [turbo](https://turborepo.com) ([source](https://github.com/vercel/turborepo)) | [`2.6.3` -> `2.7.1`](https://renovatebot.com/diffs/npm/turbo/2.6.3/2.7.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/turbo/2.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/turbo/2.6.3/2.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo (turbo)</summary> ### [`v2.7.1`](https://github.com/vercel/turborepo/releases/tag/v2.7.1): Turborepo v2.7.1 [Compare Source](vercel/turborepo@v2.7.0...v2.7.1)  #### What's Changed ##### Docs - docs: Release post for 2.7 by [@anthonyshew](https://github.com/anthonyshew) in [#11272](vercel/turborepo#11272) ##### Examples - fix: Typo in example with-solid README.md description by [@jack-dev-crypto](https://github.com/jack-dev-crypto) in [#11287](vercel/turborepo#11287) ##### Changelog - fix: Correctly validate workspace root as package by [@anthonyshew](https://github.com/anthonyshew) in [#11284](vercel/turborepo#11284) - fix: Overly aggressive path checking in microfrontends loading by [@anthonyshew](https://github.com/anthonyshew) in [#11286](vercel/turborepo#11286) - chore(boundaries): Allow packages to import themselves by [@NicholasLYang](https://github.com/NicholasLYang) in [#10202](vercel/turborepo#10202) - feat(query): Provide query for external dependencies by [@chris-olszewski](https://github.com/chris-olszewski) in [#9929](vercel/turborepo#9929) - fix: Correct version mismatch causing noUpdateNotifier to fail by [@DevaanshKathuria](https://github.com/DevaanshKathuria) in [#11133](vercel/turborepo#11133) - chore: Format version printing similar to rest of prelude by [@anthonyshew](https://github.com/anthonyshew) in [#11289](vercel/turborepo#11289) #### New Contributors - [@jack-dev-crypto](https://github.com/jack-dev-crypto) made their first contribution in [#11287](vercel/turborepo#11287) **Full Changelog**: <vercel/turborepo@v2.7.0...v2.7.1> ### [`v2.7.0`](https://github.com/vercel/turborepo/releases/tag/v2.7.0): Turborepo v2.7.0 [Compare Source](vercel/turborepo@v2.6.3...v2.7.0)  #### What's Changed ##### Docs - docs(security): Update Next.js by [@anthonyshew](https://github.com/anthonyshew) in [#11208](vercel/turborepo#11208) - docs: Remove flags code by [@anthonyshew](https://github.com/anthonyshew) in [#11209](vercel/turborepo#11209) - docs: Cleanup Sentry from gitignore by [@anthonyshew](https://github.com/anthonyshew) in [#11210](vercel/turborepo#11210) - docs: Comment out Tinybird by [@anthonyshew](https://github.com/anthonyshew) in [#11211](vercel/turborepo#11211) - docs(fix): Sitemap by [@anthonyshew](https://github.com/anthonyshew) in [#11207](vercel/turborepo#11207) - docs: Revert "Comment out Tinybird" by [@anthonyshew](https://github.com/anthonyshew) in [#11223](vercel/turborepo#11223) - docs: Move search to built-in by [@anthonyshew](https://github.com/anthonyshew) in [#11224](vercel/turborepo#11224) - docs: fix typo in design-system.css comment by [@YASHRDX0001](https://github.com/YASHRDX0001) in [#11231](vercel/turborepo#11231) - chore: Upgrade pnpm to 9 by [@anthonyshew](https://github.com/anthonyshew) in [#11226](vercel/turborepo#11226) - chore: Update pnpm to version 10 by [@anthonyshew](https://github.com/anthonyshew) in [#11237](vercel/turborepo#11237) - fix: React Server Components CVE vulnerabilities by [@vercel](https://github.com/vercel)\[bot] in [#11245](vercel/turborepo#11245) - docs: Add `turboExtendsKeyword` future flag and `$TURBO_EXTENDS$` microsyntax by [@anthonyshew](https://github.com/anthonyshew) in [#11246](vercel/turborepo#11246) - docs: Fix Bun filtered install commands by [@anthonyshew](https://github.com/anthonyshew) in [#11260](vercel/turborepo#11260) - docs: Add `turbo.json` composition docs by [@anthonyshew](https://github.com/anthonyshew) in [#11247](vercel/turborepo#11247) - feat: Turborepo Devtools by [@anthonyshew](https://github.com/anthonyshew) in [#11263](vercel/turborepo#11263) - fix: Improve layouts and task graph sourcing for devtools" by [@anthonyshew](https://github.com/anthonyshew) in [#11269](vercel/turborepo#11269) - docs: Devtools by [@anthonyshew](https://github.com/anthonyshew) in [#11270](vercel/turborepo#11270) - chore: Remove future flags for nonRootExtends and turboExtendsKeyword in preparation for stable release by [@anthonyshew](https://github.com/anthonyshew) in [#11280](vercel/turborepo#11280) ##### create-turbo - fix(cli): Preserve exit codes in notifyUpdate functions by [@pyrytakala](https://github.com/pyrytakala) in [#11153](vercel/turborepo#11153) ##### turbo-ignore - fix: Quoting in turbo-ignore commands by [@anthonyshew](https://github.com/anthonyshew) in [#11239](vercel/turborepo#11239) ##### eslint - fix: Upgrade Next.js to 15.5.7 (CVE-2025-55182) by [@ctate](https://github.com/ctate) in [#11232](vercel/turborepo#11232) ##### [@turbo/repository](https://github.com/turbo/repository) - chore: Update to Rust 1.92.0 by [@ognevny](https://github.com/ognevny) in [#11250](vercel/turborepo#11250) ##### Examples - examples(dev-deps): bump turbo from 2.6.1 to 2.6.3 in /examples/with-shell-commands by [@dependabot](https://github.com/dependabot)\[bot] in [#11217](vercel/turborepo#11217) - examples(dev-deps): bump the basic group in /examples/basic with 2 updates by [@dependabot](https://github.com/dependabot)\[bot] in [#11218](vercel/turborepo#11218) - examples(dev-deps): bump the with-svelte group in /examples/with-svelte with 3 updates by [@dependabot](https://github.com/dependabot)\[bot] in [#11219](vercel/turborepo#11219) - examples: Use slim image (debian) for prepare and builder stage, use latest no… by [@mrr11k](https://github.com/mrr11k) in [#11228](vercel/turborepo#11228) - examples(dev-deps): bump the with-svelte group in /examples/with-svelte with 2 updates by [@dependabot](https://github.com/dependabot)\[bot] in [#11254](vercel/turborepo#11254) - examples(dev-deps): bump typescript-eslint from 8.48.1 to 8.49.0 in /examples/basic in the basic group by [@dependabot](https://github.com/dependabot)\[bot] in [#11253](vercel/turborepo#11253) - examples(deps): bump react from 19.2.0 to 19.2.3 in /examples/non-monorepo by [@dependabot](https://github.com/dependabot)\[bot] in [#11255](vercel/turborepo#11255) ##### Changelog - fix(turbo-utils): Add test for conflicting configs and remove stale TODO by [@deepakpathik](https://github.com/deepakpathik) in [#11201](vercel/turborepo#11201) - feat: Yarn 4 catalogs by [@anthonyshew](https://github.com/anthonyshew) in [#11115](vercel/turborepo#11115) - fix: Add Windows-specific env var to default passthroughs by [@anthonyshew](https://github.com/anthonyshew) in [#11233](vercel/turborepo#11233) - fix: Add fine grained interruptible task restarts in watch mode by [@johnpyp](https://github.com/johnpyp) in [#11135](vercel/turborepo#11135) - perf: Find tasks impacted by packages faster by [@anthonyshew](https://github.com/anthonyshew) in [#11235](vercel/turborepo#11235) - ci: Fix release pipeline by [@anthonyshew](https://github.com/anthonyshew) in [#11240](vercel/turborepo#11240) - ci: Fix release pipeline by [@anthonyshew](https://github.com/anthonyshew) in [#11241](vercel/turborepo#11241) - fix: Compose tasks when composing turbo.json by [@anthonyshew](https://github.com/anthonyshew) in [#11248](vercel/turborepo#11248) - chore: Run pre-commit fmt on all files by [@anthonyshew](https://github.com/anthonyshew) in [#11261](vercel/turborepo#11261) - feat: Task-level `extends` field by [@anthonyshew](https://github.com/anthonyshew) in [#11259](vercel/turborepo#11259) - fix: Allow root microfrontends.json config for [@vercel/microfrontends](https://github.com/vercel/microfrontends) by [@anthonyshew](https://github.com/anthonyshew) in [#11264](vercel/turborepo#11264) - chore: Fix lint-staged and orphan GitHub Action by [@anthonyshew](https://github.com/anthonyshew) in [#11275](vercel/turborepo#11275) - chore: Remove coverage tooling by [@anthonyshew](https://github.com/anthonyshew) in [#11276](vercel/turborepo#11276) - chore: Clear false positive unused warnings by [@anthonyshew](https://github.com/anthonyshew) in [#11277](vercel/turborepo#11277) - ci: Fix flaky test (hopefully) by [@anthonyshew](https://github.com/anthonyshew) in [#11278](vercel/turborepo#11278) #### New Contributors - [@deepakpathik](https://github.com/deepakpathik) made their first contribution in [#11201](vercel/turborepo#11201) - [@YASHRDX0001](https://github.com/YASHRDX0001) made their first contribution in [#11231](vercel/turborepo#11231) - [@ctate](https://github.com/ctate) made their first contribution in [#11232](vercel/turborepo#11232) - [@johnpyp](https://github.com/johnpyp) made their first contribution in [#11135](vercel/turborepo#11135) - [@vercel](https://github.com/vercel)\[bot] made their first contribution in [#11245](vercel/turborepo#11245) **Full Changelog**: <vercel/turborepo@v2.6.3...v2.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/77 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

fix(cli): correct version mismatch causing noUpdateNotifier to fail

9df50e1

DevaanshKathuria requested a review from a team as a code owner November 18, 2025 10:26

DevaanshKathuria requested a review from tknickman November 18, 2025 10:26

DevaanshKathuria changed the title ~~fix(cli): correct version mismatch causing noUpdateNotifier to fail~~ Fix(cli): correct version mismatch causing noUpdateNotifier to fail Nov 18, 2025

DevaanshKathuria mentioned this pull request Nov 18, 2025

noUpdateNotifier does not supress update notifications #10940

Closed

1 task

DevaanshKathuria changed the title ~~Fix(cli): correct version mismatch causing noUpdateNotifier to fail~~ Fix: correct version mismatch causing noUpdateNotifier to fail Nov 18, 2025

DevaanshKathuria changed the title ~~Fix: correct version mismatch causing noUpdateNotifier to fail~~ fix: correct version mismatch causing noUpdateNotifier to fail Nov 18, 2025

DevaanshKathuria changed the title ~~fix: correct version mismatch causing noUpdateNotifier to fail~~ fix: Correct version mismatch causing noUpdateNotifier to fail Nov 18, 2025

Merge branch 'main' into noUpdateNotifier-resolved

eed39d9

vercel bot reviewed Nov 18, 2025

View reviewed changes

crates/turborepo-lib/src/shim/local_turbo_config.rs Outdated Show resolved Hide resolved

crates/turborepo-updater/src/lib.rs Outdated Show resolved Hide resolved

DevaanshKathuria and others added 4 commits November 18, 2025 23:32

Update crates/turborepo-updater/src/lib.rs

0fc5f2a

Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>

Rename parameter in infer_internal function

c2fe68d

Merge branch 'main' into noUpdateNotifier-resolved

98fb639

Merge branch 'main' into noUpdateNotifier-resolved

473b625

Merge branch 'main' into noUpdateNotifier-resolved

7369174

anthonyshew reviewed Dec 5, 2025

View reviewed changes

crates/turborepo-lib/src/shim/local_turbo_config.rs Outdated Show resolved Hide resolved

anthonyshew reviewed Dec 5, 2025

View reviewed changes

crates/turborepo-lib/src/config/mod.rs Outdated Show resolved Hide resolved

anthonyshew reviewed Dec 5, 2025

View reviewed changes

crates/turborepo-lib/src/shim/mod.rs Outdated Show resolved Hide resolved

anthonyshew requested changes Dec 5, 2025

View reviewed changes

DevaanshKathuria and others added 6 commits December 6, 2025 11:50

Update crates/turborepo-lib/src/config/mod.rs

e605e67

Co-authored-by: Anthony Shew <[email protected]>

Modify infer_internal to check is_enabled flag

f37b623

Calling the no_update_modifier in shin/mod.rs getter directly from co…

482dd0e

…nfig/mod.rs

Merge branch 'main' into noUpdateNotifier-resolved

e5bed3e

made fixes to the branch

705bc6c

Merge branch 'noUpdateNotifier-resolved' of https://github.com/Devaan…

5bfb3bb

…shKathuria/turborepo into noUpdateNotifier-resolved

anthonyshew requested changes Dec 6, 2025

View reviewed changes

Made fixes to the previous Pull Request

1c8db4d

DevaanshKathuria requested a review from anthonyshew December 14, 2025 05:47

anthonyshew and others added 4 commits December 20, 2025 10:38

Merge branch 'main' into noUpdateNotifier-resolved

9964fa5

add tests, fmt, small cleanup

cbc9ca4

undo

ea4dfb8

WIP 75cfe

bb4be19

Merge branch 'main' into noUpdateNotifier-resolved

1ad9d97

anthonyshew merged commit 3e0eefb into vercel:main Dec 20, 2025
99 checks passed

fix: Correct version mismatch causing noUpdateNotifier to fail #11133

fix: Correct version mismatch causing noUpdateNotifier to fail #11133

Conversation

DevaanshKathuria commented Nov 18, 2025 • edited by anthonyshew Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Nov 18, 2025

Uh oh!

Uh oh!

Uh oh!

DevaanshKathuria commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DevaanshKathuria commented Nov 30, 2025

Uh oh!

DevaanshKathuria commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anthonyshew left a comment

Choose a reason for hiding this comment

Uh oh!

DevaanshKathuria commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anthonyshew left a comment

Choose a reason for hiding this comment

Uh oh!

DevaanshKathuria commented Dec 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DevaanshKathuria commented Dec 12, 2025

Uh oh!

anthonyshew commented Dec 20, 2025

Uh oh!

vercel bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DevaanshKathuria commented Nov 18, 2025 •

edited by anthonyshew

Loading

DevaanshKathuria commented Nov 21, 2025 •

edited

Loading

DevaanshKathuria commented Dec 2, 2025 •

edited

Loading

DevaanshKathuria commented Dec 6, 2025 •

edited

Loading

DevaanshKathuria commented Dec 6, 2025 •

edited

Loading

vercel bot commented Dec 20, 2025 •

edited

Loading