Merged
Conversation
added 3 commits
May 25, 2022 23:12
…d in the postcondition of outline statment
jcp19
approved these changes
May 27, 2022
Contributor
jcp19
left a comment
There was a problem hiding this comment.
LGTM. I just have a few minor comments
src/main/scala/viper/gobra/frontend/info/implementation/resolution/Enclosing.scala
Outdated
Show resolved
Hide resolved
src/main/scala/viper/gobra/translator/library/outlines/OutlinesImpl.scala
Outdated
Show resolved
Hide resolved
added 2 commits
May 27, 2022 15:39
jcp19
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an outline statement. Currently, there is no way of referring to the prestate value of a variable in the postcondition, however you can use an extra variable to achieve this. I expect that we will have to introduce a new syntax element like
before(x)for this.The size of the changeset is misleading due to the generated Java files. The changeset is not particularly big.