Merged
Conversation
jcp19
approved these changes
Jul 30, 2023
Contributor
jcp19
left a comment
There was a problem hiding this comment.
LGTM. I wonder what happens when the Z3 API cannot be found though. Does it show an ugly exception or an informative error message? Would there be a way to pass a path to the Z3 API from Gobra?
jcp19
reviewed
Sep 11, 2023
Contributor
jcp19
left a comment
There was a problem hiding this comment.
I have a few minor comments. After addressing them, we can merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markus noticed a speedup when running silicon with Z3 via API in scion generated files.