Conversation
This reverts commit 76a6c13.
jcp19
approved these changes
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently upgrading the
docker/build-push-actionaction changed how published Gobra images appear (before, after).This seems to be related to multi-architecture Docker images and also manifests as an additional architecture called
unknown/unknown(cf. this issue).While the immediate workaround is fairly simple, i.e., setting
provenance: falsefor this action, I took the opportunity to add several other meta-information about our images according to the OpenContainers Annotation Spec. While all labels appear in the manifest (JSON), only the description is extracted and separately rendered by GitHub, as shown here (note that this image has been published for testing purposes, we in general do not publish images on branches).Additionally, we use several tags per image, i.e., the branch name, (short) commit hash, and
latestfor the master branch.