Merged
Conversation
Closed
Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
Contributor
Author
|
@ArquintL I have addressed your comments, please take a look at this when you find the time |
ArquintL
reviewed
Apr 3, 2025
Member
ArquintL
left a comment
There was a problem hiding this comment.
I made a pass over all unresolved comments. Please let me know if I should look at anything else
src/main/scala/viper/gobra/frontend/info/implementation/resolution/Enclosing.scala
Outdated
Show resolved
Hide resolved
src/main/scala/viper/gobra/frontend/info/implementation/typing/TypeTyping.scala
Show resolved
Hide resolved
ArquintL
reviewed
Apr 3, 2025
src/test/resources/regressions/features/globals/globals-simple01.gobra
Outdated
Show resolved
Hide resolved
ArquintL
reviewed
Apr 3, 2025
src/main/scala/viper/gobra/frontend/info/implementation/typing/ImportTyping.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ArquintL I have incorporated your feedback. This should be ready for a last look if you want to do so |
ArquintL
approved these changes
May 9, 2025
Member
ArquintL
left a comment
There was a problem hiding this comment.
I only went over the commits since my last review and have a few tiny final comments
src/main/scala/viper/gobra/frontend/info/implementation/typing/ProgramTyping.scala
Outdated
Show resolved
Hide resolved
src/main/scala/viper/gobra/frontend/info/implementation/typing/ProgramTyping.scala
Outdated
Show resolved
Hide resolved
…/ProgramTyping.scala Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
…/ProgramTyping.scala Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
openDupPkgInvto open the duplicable invariants of the current package if initialization is guaranteed to be finished, and we introduce all necessary proof obligations for theinitfunctions andmainfunction.mayInit) to make sure we never open invariants that might not hold yet - more details on this sooninitEnsuresclauses to allow for modularly checking a package. We also deprecate the--lazyImportsflag, as it is no longer necessary: If the package under verification does not declare any package invariants norinitRequiresclauses, then nothing is checked for that package. Because our methodology is now modular, we do not have to re-check initialization of all imported packages.same_package/import-fail01/mainfails non-deterministically #762Minor TODOs:
--enableFriendClauses