Conversation
55b7f7e to
91c10fe
Compare
jcp19
approved these changes
Jan 21, 2025
Contributor
jcp19
left a comment
There was a problem hiding this comment.
LGTM, I just have a few minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
--disablePluginsflag for ViperServer-based backends, fixes invalid command line options that are passed to Carbon (with and without ViperServer), and adds a simple testcase for each backed.Adding testcases required changing
Configand the way we merge in-file configuration options. In particular, I madebackendoptional such that we know while merging configuration options whether a backend has been specified or not. We emit a violation if one attempts to merge differing backends as the merge strategy is unclear in this case.Closes #823