Conversation
jcp19
approved these changes
Feb 26, 2025
Comment on lines
+566
to
+568
| case class Old(operand: Expr)(val info: Source.Parser.Info) extends Expr { | ||
| override def typ: Type = operand.typ.withAddressability(Addressability.rValue) | ||
| } |
Contributor
There was a problem hiding this comment.
Ah, interesting. I guess we never considered the case where we would pass a shared value. I guess this case never makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue seems related to old and labeled old expressions involving structs. In particular, we used the same addressability as old's argument. Thus, the encoding tried to handle the result of an old expression in the issue's example as a shared struct even though it is an exclusive struct.
000629-3.gobratried to reproduce the same issue without using structs but this did not trigger the issue and this test case has been added just for completeness.Fixes #620