Skip to content

errors.New#909

Merged
ArquintL merged 4 commits intomasterfrom
errors-new
Apr 2, 2025
Merged

errors.New#909
ArquintL merged 4 commits intomasterfrom
errors-new

Conversation

@ArquintL
Copy link
Member

@ArquintL ArquintL commented Apr 2, 2025

This PR extends the errors package to (finally!) provide the New function.

@ArquintL ArquintL requested a review from jcp19 April 2, 2025 09:22
@ArquintL
Copy link
Member Author

ArquintL commented Apr 2, 2025

@jcp19 Was there a particular reason to add wrap.go but not errors.go? It seems strange to me that we provide (some advanced) parts of the errors package but not the most basic one

@jcp19
Copy link
Contributor

jcp19 commented Apr 2, 2025

@jcp19 Was there a particular reason to add wrap.go but not errors.go? It seems strange to me that we provide (some advanced) parts of the errors package but not the most basic one

the reason is that I never needed errors.go 😄

Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArquintL ArquintL enabled auto-merge (squash) April 2, 2025 09:50
@ArquintL ArquintL merged commit ac4a94b into master Apr 2, 2025
3 checks passed
@ArquintL ArquintL deleted the errors-new branch April 2, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants