Skip to content

Allow disabling of auto prepending the field labels.#325

Merged
willemwollebrants merged 4 commits into
vlucas:masterfrom
TomOudeRengerink:disable-auto-prepend-field-label
Dec 1, 2020
Merged

Allow disabling of auto prepending the field labels.#325
willemwollebrants merged 4 commits into
vlucas:masterfrom
TomOudeRengerink:disable-auto-prepend-field-label

Conversation

@TomOudeRengerink

Copy link
Copy Markdown

Created a new setter to disable the prepending of field labels that are outputted in the error messages.

By default it's condition is true so it's backwards compatible.

@willemwollebrants

willemwollebrants commented Oct 25, 2020

Copy link
Copy Markdown
Collaborator

Thank you for your work so far. Could you please add some tests to test and show off the new behavior?

@TomOudeRengerink

Copy link
Copy Markdown
Author

All checks have passed with the new provided test.

@zogot

zogot commented Dec 1, 2020

Copy link
Copy Markdown

Any chance for getting this in? It also looks like all current 3 open PR's are to solve this same problem.

@willemwollebrants willemwollebrants merged commit 81515dc into vlucas:master Dec 1, 2020
@willemwollebrants

Copy link
Copy Markdown
Collaborator

I somehow missed the update with the tests :o Thanks for your work and patience @TomOudeRengerink , and thanks for the reminder @zogot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants