Skip to content

Conversation

@yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jun 9, 2025

Description

Add Azure module for Wazuh dashboard, with custom visualizations and information.

Issues Resolved

Evidence

Screenshots

screencapture-localhost-5601-app-wz-home-2025-07-22-19_19_13 screencapture-localhost-5601-app-sample-data-2025-07-22-19_17_24 screencapture-localhost-5601-app-azure-2025-07-24-22_33_40 screencapture-localhost-5601-app-azure-2025-07-24-22_33_56

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Azure sample data with ms-graph must be added correctly
From the overview you should be able to navigate to the Azure dashboard.
From the side menu you should be able to navigate to the Azure dashboard.
The dashboard view must render correctly with and without a pinned agent.
The events view must render correctly with and without pinned agent

Details

⚫ Azure sample data with ms-graph must be added correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ From the overview you should be able to navigate to the Azure dashboard.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ From the side menu you should be able to navigate to the Azure dashboard.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ The dashboard view must render correctly with and without a pinned agent.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ The events view must render correctly with and without pinned agent

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Jun 9, 2025 that may be closed by this pull request
Introduces comprehensive Azure integration including data source filtering, dashboard visualizations, and event column definitions.

Creates Azure-specific data source class with rule group filtering capabilities and establishes dashboard panels for both overview and agent-specific views.

Implements module configuration with placeholder AWS field mappings as temporary solution until Azure data structure becomes available.

Updates application icon to use Azure mono variant for consistent branding.
Copy link

@Firefly0 Firefly0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to dismiss my review: I m practicing my review skills and wazuh seems like an interesting project where I can contribute

@yenienserrano yenienserrano self-assigned this Jun 24, 2025
@asteriscos asteriscos marked this pull request as ready for review June 30, 2025 12:15
@Machi3mfl Machi3mfl self-requested a review June 30, 2025 12:46
Machi3mfl
Machi3mfl previously approved these changes Jun 30, 2025
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screen.Recording.2025-06-30.at.4.24.45.PM.mov

guidomodarelli
guidomodarelli previously approved these changes Jul 1, 2025
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Test Legend

Symbol Meaning
The test hasn't started yet.
🟢 All checks passed.
🟡 There is at least one expected fail or skipped test and no failures.
🔴 There is at least one failed check.
Doesn't apply.
🔧 Request changes.
Needs more information.

🧪 Test 2025/07/01

CR 🟢
TEST 🟢

Screen.Recording.2025-07-01.142004.mp4

Migrates Azure module from generic Azure API fields to Microsoft Graph-specific data structure. Changes field mappings from generic names like 'Result', 'OperationName', 'Category' to MS Graph-specific fields like 'activityResult', 'activityOperationType', 'category' under the 'ms-graph' namespace.

Updates dashboard visualizations, data source filters, and sample data generation to reflect the new MS Graph field structure. Improves data accuracy and alignment with Microsoft Graph API specifications.
@yenienserrano yenienserrano dismissed stale reviews from Machi3mfl and guidomodarelli via 4628e72 July 22, 2025 17:16
guidomodarelli
guidomodarelli previously approved these changes Jul 22, 2025
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🟢

Replaces risk level and status pie charts with display name and category tables to improve data readability and analysis capabilities.

Updates field mappings to use displayName instead of activity in data grids and removes deprecated status field from known fields configuration.

Enhances sample data generation with new displayName array and improves date handling for more realistic test data.
Updates dashboard panel titles to use consistent lowercase capitalization for better UI uniformity across Azure overview and agent dashboard components.
@guidomodarelli
Copy link
Contributor

🟢 Test Legend

Symbol Meaning
The test hasn't started yet.
🟢 All checks passed.
🟡 There is at least one expected fail or skipped test and no failures.
🔴 There is at least one failed check.
Doesn't apply.
🔧 Request changes.
Needs more information.

🧪 UI Tests

Test Description Chrome
1️⃣ In Azure module: Add sample data with ms-graph → Data should appear correctly
2️⃣ In Azure > Overview: Click Azure card → Should navigate to Azure dashboard
3️⃣ In Side Menu: Click on "Azure" → Should navigate to Azure dashboard
4️⃣ In Azure > Dashboard: Load view with and without a pinned agent → UI should render correctly
5️⃣ In Azure > Events: Load view with and without a pinned agent → UI should render correctly

📋Test Details

⚫ 1️⃣ In **Azure module**: Add sample data with *ms-graph* → Data should appear correctly

CHROME - ⚫

⚫ 2️⃣ In **Azure > Overview**: Click Azure card → Should navigate to Azure dashboard

CHROME - ⚫

⚫ 3️⃣ In **Side Menu**: Click on "Azure" → Should navigate to Azure dashboard

CHROME - ⚫

⚫ 4️⃣ In **Azure > Dashboard**: Load view with and without a pinned agent → UI should render correctly

CHROME - ⚫

⚫ 5️⃣ In **Azure > Events**: Load view with and without a pinned agent → UI should render correctly

CHROME - ⚫

Consolidates dashboard panels by removing redundant category visualizations and reorganizing grid layout for better space utilization.

Increases activity result visualization size from 5 to 10 items for more comprehensive data display.

Adjusts column widths in events table for improved readability of display names and activity results.
@github-actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.01% ( 397 / 882 )
Branches 41.09% ( 157 / 382 )
Functions 42.67% ( 134 / 314 )
Lines 45.19% ( 395 / 874 )

@github-actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 78.72% ( 185 / 235 )
Branches 62.72% ( 69 / 110 )
Functions 61.7% ( 29 / 47 )
Lines 78.72% ( 185 / 235 )

@github-actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 16.42% ( 5013 / 30520 )
Branches 10.48% ( 2034 / 19400 )
Functions 17.44% ( 1301 / 7459 )
Lines 16.67% ( 4901 / 29398 )

Copy link
Contributor

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox
Azure sample data with ms-graph must be added correctly 🟢 🟢
From the overview you should be able to navigate to the Azure dashboard. 🟢 🟢
From the side menu you should be able to navigate to the Azure dashboard. 🟢 🟢
The dashboard view must render correctly with and without a pinned agent. 🟢 🟢
The events view must render correctly with and without pinned agent 🟢 🟢

Details

🟢 Azure sample data with ms-graph must be added correctly

Chrome - 🟢

Image Image

Firefox - 🟢

Image Image
🟢 From the overview you should be able to navigate to the Azure dashboard.

Chrome - 🟢

Image

Firefox - 🟢

Image

🟢 From the side menu you should be able to navigate to the Azure dashboard.

Chrome - 🟢

Image

Firefox - 🟢

Image

🟢 The dashboard view must render correctly with and without a pinned agent.

Chrome - 🟢

Image Image

Firefox - 🟢

Image Image
🟢 The events view must render correctly with and without pinned agent

Chrome - 🟢

Image Image

Firefox - 🟢

Image Image

CR 🟢

LGTM

@gonzaarancibia gonzaarancibia self-requested a review July 28, 2025 17:41
@gonzaarancibia
Copy link
Member

gonzaarancibia commented Jul 28, 2025

Test 🟡

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Safari
Azure sample data with ms-graph must be added correctly 🟡 The first render show the map without the points, after I click the map this render the points. 🟡 The first render show the map without the points, after I click the map this render the points.
From the overview you should be able to navigate to the Azure dashboard. 🟢 🟢
From the side menu you should be able to navigate to the Azure dashboard. 🟢 🟢
The dashboard view must render correctly with and without a pinned agent. 🟢 🟢
The events view must render correctly with and without pinned agent 🟢 🟢

Details

🟡 Azure sample data with ms-graph must be added correctly The first render show the map without the points, after I click the map this render the points.

Chrome - 🟢
Screenshot 2025-07-28 at 6 27 35 PM
Screenshot 2025-07-28 at 6 29 47 PM

Screen.Recording.2025-07-28.at.6.44.43.PM.mov

Safari - 🟢

Screenshot 2025-07-28 at 6 28 50 PM Screenshot 2025-07-28 at 6 30 20 PM Screenshot 2025-07-28 at 6 31 38 PM
🟢 From the overview you should be able to navigate to the Azure dashboard.

Chrome - 🟢

Screen.Recording.2025-07-28.at.6.35.22.PM.mov

Safari - 🟢

Screen.Recording.2025-07-28.at.6.36.14.PM.mov
🟢 From the side menu you should be able to navigate to the Azure dashboard.

Chrome - 🟢

Screen.Recording.2025-07-28.at.6.37.08.PM.mov

Safari - 🟢

Screen.Recording.2025-07-28.at.6.37.35.PM.mov
🟢 The dashboard and the events views must render correctly with and without a pinned agent.

Chrome - 🟢

Screen.Recording.2025-07-28.at.6.38.47.PM.mov

Safari - 🟢

Screen.Recording.2025-07-28.at.6.39.15.PM.mov

CR 🟢

LGTM

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

localhost_5601_app_wz-home

@Tostti Tostti merged commit a1527ff into 4.14.0 Jul 29, 2025
5 checks passed
@Tostti Tostti deleted the enhancement/7514-create-azure-module branch July 29, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Azure module

7 participants