Skip to content

[FedCM] Prototype User Info API behind a flag (2/3) #38044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 18, 2023

User Info API can be used by IDPs to render personalized buttons. See
proposal at w3c-fedid/FedCM#382.

This patch:

  • Implement the proposal to return the requested user info.

Next:

  • Add metrics and console logs

This patch is built on top of crrev.com/c/4117510

Bug: 1304402
Change-Id: Iaee7a1b716b20182b56ebd484d3fecd03a31ba49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4175904
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Nicolás Peña <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1095226}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-4175904 branch 7 times, most recently from 0bf9e67 to cc35238 Compare January 20, 2023 21:48
User Info API can be used by IDPs to render personalized buttons. See
proposal at w3c-fedid/FedCM#382.

This patch:
 - Implement the proposal to return the requested user info.

Next:
 - Add metrics and console logs

This patch is built on top of crrev.com/c/4117510

Bug: 1304402
Change-Id: Iaee7a1b716b20182b56ebd484d3fecd03a31ba49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4175904
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Nicolás Peña <[email protected]>
Reviewed-by: Ken Buchanan <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1095226}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants