Change the boundary checks when the condition value is exactly 0 #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case for free shipping)
Closed
|
Hello @barbazul, I've raised this to our development team for further assessment. Thank you for your feedback, let us know if you have any questions. Lewis Kennedy - ShipperHQ / WebShopApps Support |
|
This should be fixed, we just used for starting values a negative -1 but this is just an ugly workaround |
|
Hello @santibm thanks for following up. I wanted to let you know that we're looking to get this reviewed during the current quarter. We appreciate the feedback here. Lewis Kennedy - ShipperHQ/WebShopApps Support |
Contributor
|
Thanks for raising this issue. This has been addressed in version 20.4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with free shipping scenarios, the package weight and values get set to 0.
The way Matrixrates is checking for rates only matches on strict "lower than" which will never match a vlaue of 0 (as there are no negative wegihts or values).
This PR treats the condition value of 0 as an exception to change how the rate boundaries are checked against