Updates logic to get shipping rates #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This should already be caught in the check that is in: Model/ResourceModel/Carrier/Matrixrate.php around line 301 The check is: |
Contributor
|
Closing as I didn't hear back. Please let me know if this is still an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug where the getFreeMethodWeight() function is dependent on a value other than null is being returned to build the shipping rate array.
Use Case:
On Magento stores, applying a coupon that has a fixed discount for both the subtotal and shipping cost will throw an error for shipping total when the ratesArray is empty. This is inevitable when getFreeMethodWeight() returns null.