condition_from_value set as valid value #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition_from_value was not used as a valid value. When you had a rate from 0 to 5 Then 0 wasn't valid, but 5 was. (Making products with a price of 0, not have this rate available)
Contributor
|
We can't accept this pull request as it would break the extension for anyone else using it. The correct solution is to use * in the CSV file. That will set the condition_from_value to -1 in the database and fix the issue you've raised |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition_from_value was not used as a valid value.
When you had a rate from 0 to 5
Then 0 wasn't valid, but 5 was. (Making products with a price of 0, not have this rate available)