Update Matrixrate.php #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entrou em conflito com máscaras de CEP, acho prudente retirar o hífen.
Contributor
|
Hi daniloaldm! Thanks for this contribution, I've added it to the schedule for review. |
Author
|
@wsadasmit Any feedback? |
wsajosh
requested changes
Dec 21, 2020
Contributor
There was a problem hiding this comment.
Thanks for the contribution but I'm not happy to merge this right now. It has the potential to break other configurations if the user is specifically looking for hyphens using pattern matching. If you were to change the PR to only make the change if the country is Brazil and $zipRangeSet is true then I think it would be safer. Please go ahead and re-open the pull request if you decide to change the implementation and I'll re-review it and merge it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entrou em conflito com máscaras de CEP, acho prudente retirar o hífen.