This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Fix error message when exception is created#17
Merged
weierophinney merged 1 commit intozendframework:masterfrom Jan 16, 2017
Merged
Fix error message when exception is created#17weierophinney merged 1 commit intozendframework:masterfrom
weierophinney merged 1 commit intozendframework:masterfrom
Conversation
Member
|
Please add a test because if the value is not string will be difficult to be casted to string for render the error message. I think the exception message should be changed anyway. |
Member
|
The patch as provided is incorrect, and will result in errors when resources and objects are provided. I'll fix that on merge. |
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2017
Fix error message when exception is created
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2017
weierophinney
added a commit
that referenced
this pull request
Jan 16, 2017
Member
|
Thanks, @GrzegorzDrozd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following error message:
Fatal error: Wrong parameters for Exception([string $exception [, long $code [, Exception $previous = NULL]]]) /vendor/zendframework/zend-mime/src/Part.php on line 271