This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Merged
Conversation
nicolashohm
suggested changes
Feb 21, 2018
src/Mime.php
Outdated
| // Check if there is a space at the end of the line and rewind | ||
| if ($ptr > 0 && $str[$ptr - 1] == ' ') { | ||
| --$ptr; | ||
| switch (ord($str[0])) { |
src/Mime.php
Outdated
| if ($ptr > 0 && $str[$ptr - 1] == ' ') { | ||
| --$ptr; | ||
| switch (ord($str[0])) { | ||
| case 0x2E: |
There was a problem hiding this comment.
would be easier to read if you add an comment with the translation of the hex code
| break; | ||
| } | ||
|
|
||
| switch (ord(substr($str, $ptr - 1))) { |
There was a problem hiding this comment.
you got these code from somethere else? please add a link in comments or commit message
Added some comments, rebuilt switch into if
added another comment for better understanding
Rfrost92
approved these changes
Mar 13, 2018
Rfrost92
approved these changes
Mar 13, 2018
Rfrost92
left a comment
There was a problem hiding this comment.
Tested these changes in our mail system, everything seems to work fine. The bug is fixed
2 tasks
usox
approved these changes
Mar 26, 2018
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
Forward port #32 Conflicts: CHANGELOG.md
Member
|
Thanks, @EugenGanshorn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a message contains 72 spaces and 72 dots at one line we have an infinite loop. This pull request fix this behavior.
I'll replace the last space at one line always with =20. I'll also replace the first dot at one line always with =2E.
Swiftmail do it the same way and it works fine.