Skip to content

Create subject counts on collection - #4625

Merged
yuenmichelle1 merged 9 commits into
masterfrom
create-subject-counts-on-collection
Jun 15, 2026
Merged

Create subject counts on collection#4625
yuenmichelle1 merged 9 commits into
masterfrom
create-subject-counts-on-collection

Conversation

@yuenmichelle1

@yuenmichelle1 yuenmichelle1 commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Create a counter_cache column (subjects_count) in order to filter out collections by number of subjects.
#4577

TODO after merge, deploy, migration

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

Comment thread db/migrate/20260520193213_add_subjects_count_to_collections.rb
Comment thread lib/tasks/collections.rake
@yuenmichelle1
yuenmichelle1 marked this pull request as ready for review June 2, 2026 14:50
@yuenmichelle1
yuenmichelle1 requested a review from Tooyosi June 9, 2026 14:26
@yuenmichelle1 yuenmichelle1 linked an issue Jun 9, 2026 that may be closed by this pull request
Comment thread lib/tasks/collections.rake Outdated
@yuenmichelle1
yuenmichelle1 merged commit 3ad99d3 into master Jun 15, 2026
12 checks passed
@yuenmichelle1
yuenmichelle1 deleted the create-subject-counts-on-collection branch June 15, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow filtering of collections with fewer than 1 or 2 subjects

2 participants