Add support for react-native-web #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoontek
requested changes
Sep 24, 2019
Owner
|
@jwaldrip Awesome contrib! 👏🏼 I requested a few changes, nothing too fancy. |
zoontek
requested changes
Sep 24, 2019
zoontek
reviewed
Sep 24, 2019
Contributor
Author
|
@zoontek all changes have been implemented. |
zoontek
approved these changes
Oct 5, 2019
Owner
|
@jwaldrip Thanks, it's merged! |
Contributor
|
@jwaldrip as the current react-native-device-info, very sorry for the hassle - I didn't realize there would be a react-native-web impact with the API move here, thanks very much for helping other web API consumers out with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for react-native-web. Moving from RN device info, which had web support, broke our apps.
Checklist
README.md