Project

General

Profile

Actions
Copy link

Bug #14495

closed

Enumerator::Lazy#uniq invalid state

Added by chopraanmol1 (Anmol Chopra) about 7 years ago. Updated over 6 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.5.0preview1 (2017-10-10 trunk 60153) [x86_64-linux]
Backport:
2.3: UNKNOWN, 2.4: DONE, 2.5: DONE
[ruby-core:85646]

Description

Currently

2.5.0-preview1 :001 > arr = (0..100).lazy.uniq{|i| i % 10}
 => #<Enumerator::Lazy: #<Enumerator::Lazy: 0..100>:uniq> 
2.5.0-preview1 :002 > arr.to_a
 => [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] 
2.5.0-preview1 :003 > arr.to_a
 => []

Expected

2.5.0-preview1 :001 > arr = (0..100).lazy.uniq{|i| i % 10}
 => #<Enumerator::Lazy: #<Enumerator::Lazy: 0..100>:uniq> 
2.5.0-preview1 :002 > arr.to_a
 => [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] 
2.5.0-preview1 :003 > arr.to_a
 => [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]

Solution Enumerator::Lazy#uniq's hash should be accessed from yielder memo

Actions
Copy link
 #2 [ruby-core:86309]

Updated by Eregon (Benoit Daloze) about 7 years ago

Should this be backported?

Actions
Copy link
 #3 [ruby-core:86334]

Updated by chopraanmol1 (Anmol Chopra) about 7 years ago

Yes, to 2.4 and 2.5

Actions
Copy link
 #4

Updated by nagachika (Tomoyuki Chikanaga) almost 7 years ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: REQUIRED
Actions
Copy link
 #5 [ruby-core:87741]

Updated by nagachika (Tomoyuki Chikanaga) almost 7 years ago

  • Backport changed from 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: REQUIRED to 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: DONE

ruby_2_5 r63824 merged revision(s) 62731,62735.

Actions
Copy link
 #6

Updated by nagachika (Tomoyuki Chikanaga) almost 7 years ago

  • Status changed from Open to Closed

Applied in changeset ruby_2_5|r63824.

merge revision(s) 62731,62735: [Backport #14495]

Bug Fix Enumerator::Lazy#uniq state for multiple call

* enumerator.c (lazy_uniq_i): create new hash for each calls.
  [Fix GH-1820]

Currently

	2.5.0-preview1 :001 > arr = (0..100).lazy.uniq{|i| i % 10}
	 => #<Enumerator::Lazy: #<Enumerator::Lazy: 0..100>:uniq>
	2.5.0-preview1 :002 > arr.to_a
	 => [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
	2.5.0-preview1 :003 > arr.to_a
	 => []

Expected

arr.to_a to always return same output

From: Anmol Chopra <[email protected]>

test_enumerator.rb: duplicate assertions

* test/ruby/test_enumerator.rb (test_uniq): remove assertions
  which ared duplicate of lazy enumerator tests in
  test_lazy_enumerator.rb.
Actions
Copy link
 #7 [ruby-core:88688]

Updated by usa (Usaku NAKAMURA) over 6 years ago

  • Backport changed from 2.3: UNKNOWN, 2.4: REQUIRED, 2.5: DONE to 2.3: UNKNOWN, 2.4: DONE, 2.5: DONE

ruby_2_4 r64558 merged revision(s) 62731,62735.

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0