Bug #5459
closed
Silence -Wmissing-declarations and -Wold-style-definition warnings in mkmf
Description
The attached patch silences -Wmissing-declarations and -Wold-style-definition warnings in c files generated by mkmf. This is required, as mkmf uses $CFLAGS when running the c compiler on the generated c files.
Files
Updated by shyouhei (Shyouhei Urabe) over 13 years ago
+1. It seems harmless.
Updated by kosaki (Motohiro KOSAKI) over 13 years ago
I reviewed your patch. +1 me too.
Updated by kosaki (Motohiro KOSAKI) over 13 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r33834.
Nikolai, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
- lib/mkmf.rb: get rid of warnings of mkmf.rb if -Wmissing-declarations
and/or -Wold-style-definition warnings if specified.
Patch by Nikolai Weibull. Thank you! [Bug #5459] [ruby-core:40200]
Updated by nobu (Nobuyoshi Nakada) over 13 years ago
Generic notes:
- Use the latest version.
- Don't make a patch from installed files.
- Don't overwrite conflicts blindly.
Updated by now (Nikolai Weibull) over 13 years ago
On Fri, Dec 2, 2011 at 02:05, Nobuyoshi Nakada [email protected] wrote:
Issue #5459 has been updated by Nobuyoshi Nakada.
Generic notes:
- Use the latest version.
- Don't make a patch from installed files.
- Don't overwrite conflicts blindly.
I’m sorry, but I don’t understand. Where these notes aimed at me? I
wrote the patch against the trunk branch of the Git repository and I
don’t know what you mean by conflicts.