Project

General

Profile

Actions
Copy link

Bug #5736

closed

Numeric#quo should convert with #to_r

Added by john_firebaugh (John Firebaugh) over 13 years ago. Updated almost 12 years ago.

Status:
Closed
Assignee:
mrkn (Kenta Murata)
Target version:
-
ruby -v:
ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-darwin10.8.0]
Backport:
[ruby-core:41575]

Description

Numeric#quo currently constructs a Rational with self as the raw numerator, doing no coercion, before dividing. Instead it should follow the same pattern as Numeric#{numerator,denominator}, and convert self with #to_r. This allows any Numeric subclass to participate in the type conversion.

Files

0001-numeric.c-num_quo-Convert-to-Rational-using-to_r.patch (1.52 KB) 0001-numeric.c-num_quo-Convert-to-Rational-using-to_r.patch Patch john_firebaugh (John Firebaugh), 12/10/2011 06:17 AM
Actions
Copy link
 #2

Updated by ko1 (Koichi Sasada) about 13 years ago

  • Assignee set to mrkn (Kenta Murata)
Actions
Copy link
 #3

Updated by shyouhei (Shyouhei Urabe) about 13 years ago

  • Status changed from Open to Assigned
Actions
Copy link
 #4

Updated by mrkn (Kenta Murata) almost 12 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41109.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

  • numeric.c (num_quo): Use to_r method to convert the receiver to
    rational. [ruby-core:41575] [Bug #5736]

  • test/ruby/test_numeric.rb: add a test for the above change.

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0Like0