Changeset 247349 in webkit for trunk/Source/WebCore/ChangeLog

Timestamp:

Jul 11, 2019, 6:36:50 AM (6 years ago)

Author:

[email protected]

Message:

AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
​https://bugs.webkit.org/show_bug.cgi?id=199692

Reviewed by Chris Fleizach.

Source/WebCore:

Create new AccessibilityRole types which correspond to the new ARIA roles and
update AccessibilityRenderObject::determineAccessibilityRole() to assign these
internal roles to the related HTML elements.

Update both ATK and Mac to recognize these new internal roles. In addition, update
the ATK mappings for the ins and del elements to ATK_ROLE_CONTENT_INSERTION and
ATK_ROLE_CONTENT_DELETION respectively. Also expose "insertion" and "deletion" via
the AtkObject xml-roles attribute so that this information is not completely absent
for GTK or WPE built against earlier versions of ATK.

Remove AccessibilityObject's isSubscriptStyleGroup() and isSuperscriptStyleGroup().
These two methods were only being used by ATK and are no longer needed for platform
role mapping.

No new tests. Instead add the roles to the existing role-exposure tests.

• accessibility/AccessibilityObject.cpp:

(WebCore::initializeRoleMap):
(WebCore::AccessibilityObject::isSubscriptStyleGroup const): Deleted.
(WebCore::AccessibilityObject::isSuperscriptStyleGroup const): Deleted.

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

• accessibility/atk/WebKitAccessible.cpp:

(webkitAccessibleGetAttributes):
(atkRole):

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):

Tools:

Add support for output of AXDeletion and AXInsertion roles for tests.
Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.

• WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
• gtk/jhbuild.modules:
• wpe/jhbuild.modules:

LayoutTests:

Add the new roles to the existing role-exposure tests and update expectations accordingly.

• accessibility/gtk/object-attributes-expected.txt:
• accessibility/gtk/object-attributes.html:
• accessibility/gtk/xml-roles-exposed-expected.txt:
• accessibility/gtk/xml-roles-exposed.html:
• accessibility/roles-computedRoleString.html:
• accessibility/roles-exposed.html:
• platform/gtk/accessibility/roles-computedRoleString-expected.txt:
• platform/gtk/accessibility/roles-exposed-expected.txt:
• platform/mac-wk2/accessibility/roles-exposed-expected.txt:
• platform/mac/accessibility/roles-computedRoleString-expected.txt:
• platform/mac/accessibility/roles-exposed-expected.txt:
• platform/wpe/accessibility/roles-computedRoleString-expected.txt:
• platform/wpe/accessibility/roles-exposed-expected.txt:

File:

• trunk/Source/WebCore/ChangeLog (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-11  Joanmarie Diggs  <[email protected]>
+
+        AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
+        https://bugs.webkit.org/show_bug.cgi?id=199692
+
+        Reviewed by Chris Fleizach.
+
+        Create new AccessibilityRole types which correspond to the new ARIA roles and
+        update AccessibilityRenderObject::determineAccessibilityRole() to assign these
+        internal roles to the related HTML elements.
+
+        Update both ATK and Mac to recognize these new internal roles. In addition, update
+        the ATK mappings for the ins and del elements to ATK_ROLE_CONTENT_INSERTION and
+        ATK_ROLE_CONTENT_DELETION respectively. Also expose "insertion" and "deletion" via
+        the AtkObject xml-roles attribute so that this information is not completely absent
+        for GTK or WPE built against earlier versions of ATK.
+
+        Remove AccessibilityObject's isSubscriptStyleGroup() and isSuperscriptStyleGroup().
+        These two methods were only being used by ATK and are no longer needed for platform
+        role mapping.
+
+        No new tests. Instead add the roles to the existing role-exposure tests.
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::initializeRoleMap):
+        (WebCore::AccessibilityObject::isSubscriptStyleGroup const): Deleted.
+        (WebCore::AccessibilityObject::isSuperscriptStyleGroup const): Deleted.
+        * accessibility/AccessibilityObject.h:
+        * accessibility/AccessibilityObjectInterface.h:
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+        * accessibility/atk/WebKitAccessible.cpp:
+        (webkitAccessibleGetAttributes):
+        (atkRole):
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (createAccessibilityRoleMap):
+        (-[WebAccessibilityObjectWrapper subrole]):
+
 2019-07-11  Thibault Saunier  <[email protected]>