Minor addition to index documentation

Lists: pgsql-docs
From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: pgsql-docs(at)postgresql(dot)org
Subject: Minor addition to index documentation
Date: 2015-11-16 15:33:18
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs

Fix incomplete gist interface description.
Patch is attached.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
gist_fetch_docs_update.patch text/x-patch 855 bytes
From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Cc: pgsql-docs(at)postgresql(dot)org
Subject: Re: Minor addition to index documentation
Date: 2015-11-16 18:59:19
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs

Anastasia Lubennikova wrote:
> Fix incomplete gist interface description.

Hi, thanks for the patch.

I think this sentence is a bit confusing:

> <para>
> - GiST indexes require seven support functions, with an optional eighth, as
> + GiST indexes require seven support functions, with two optional, as
> shown in <xref linkend="xindex-gist-support-table">.

The new text seems to say that one of the seven support funcs is
optional, which is wrong if I correctly understand that the "fetch"
optional function was added.

Maybe "GiST indexes require nine support functions, two of which are
optional, as shown in XYZ".

This is to be backpatched as far back as commit d04c8ed9044ec, right?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: pgsql-docs(at)postgresql(dot)org
Subject: Re: Minor addition to index documentation
Date: 2015-11-17 09:40:50
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs

16.11.2015 21:59, Alvaro Herrera:
> Anastasia Lubennikova wrote:
>> Fix incomplete gist interface description.
> Hi, thanks for the patch.
>
> I think this sentence is a bit confusing:
>
>> <para>
>> - GiST indexes require seven support functions, with an optional eighth, as
>> + GiST indexes require seven support functions, with two optional, as
>> shown in <xref linkend="xindex-gist-support-table">.
> The new text seems to say that one of the seven support funcs is
> optional, which is wrong if I correctly understand that the "fetch"
> optional function was added.
>
> Maybe "GiST indexes require nine support functions, two of which are
> optional, as shown in XYZ".
Yes, thank you for advice. I think it'll be more clear.

> This is to be backpatched as far back as commit d04c8ed9044ec, right?
Yes.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
gist_fetch_docs_update_1.0.patch text/x-patch 862 bytes
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, pgsql-docs(at)postgresql(dot)org
Subject: Re: Minor addition to index documentation
Date: 2015-12-06 17:45:14
Message-ID: [email protected]
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-docs

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Maybe "GiST indexes require nine support functions, two of which are
> optional, as shown in XYZ".

That wording seems just as bizarre to me: a support function can hardly
be both "required" and "optional". After a bit of thought I changed it
to
GiST indexes have nine support functions, two of which are optional,

I noted that the corresponding wording for GIN indexes was a bit out
of date too :-(. Pushed with those corrections.

regards, tom lane