Patch #28934
closed
I attach a patch to add simple unit test.
I hope to fix this issue :)
- Category changed from Performance to Rails support
- Target version set to 4.0.0
+1 this patch is needed to migrate a plugin by redmine:plugins:migrate on rails 5.2.
I think release version like 3.4.x is NOT going to support Rails 5.2, keep 4.x.
So I created a patch which is removed condition of Rails version check for older than trunk.
I attatch it, and it includes add_unittest.patch.
@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.
Btw: my patch also loads schema_migrations only once for all plugins, so there's also a performance impact if you have more plugins installed.
Unfortunatelly I have to duplicate MigrationContext because it calls back the original Migrator class from Rails not the patched one by Redmine. Maybe someone can figure out a better solution.
Pavel Rosický wrote:
@Tatsuya Saito
I agree we can remove the rails version check. Your patch is simple, but wrong. It produces invalid entries in schema_migrations! without a plugin_name suffix.
Thanks comment and sorry broke your patch.
I fix and attach it.
It's ok. Thanks for testing
- Subject changed from [Rails 5.2] support migration context to Support migration context for plugins
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Has duplicate Defect #29291: NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:Class added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by