Skip to content

refs #955: deprecate Client::AUTH_* constants and replace them with AuthMethod::AUTH_* const #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 2, 2021
Merged

refs #955: deprecate Client::AUTH_* constants and replace them with AuthMethod::AUTH_* const #1036

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11c2d9f
refs #955: deprecate Client::AUTH_* constants and replace them with A…
ipalo Oct 30, 2021
f4774d0
refs #955: revert the Client::AUTH_* deletion (BC)
ipalo Oct 30, 2021
e7f1ab9
refs #955: fix CR issues
ipalo Oct 31, 2021
c9cf54e
refs #955: add upgrade to v4.0 notes
ipalo Oct 31, 2021
ec6656c
refs #955: set public all constants
ipalo Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refs #955: add upgrade to v4.0 notes
  • Loading branch information
@ipalo
ipalo committed Oct 31, 2021
commit c9cf54e65f7010821d224dfc96ada2a226ce9e81
6 changes: 6 additions & 0 deletions UPGRADE-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@
### ResultPager

* `\Github\ResultPagerInterface::postFetch` is deprecated, and the method will be removed from the ResultPager interface/class.

### Authentication methods

* `Github\Client::AUTH_CLIENT_ID` is deprecated, use `Github\AuthMethod::CLIENT_ID` instead.
* `Github\Client::AUTH_ACCESS_TOKEN` is deprecated, use `Github\AuthMethod::ACCESS_TOKEN` instead.
* `Github\Client::AUTH_JWT` is deprecated, use `Github\AuthMethod::JWT` instead.