Bump MacOS CI to macOS-13
#2579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f2f3ff to
bcbaab4
Compare
macOS-12/20231029.1macOS-13
|
I've added a flaky label, let's see the results. We could add a work-around, similar to the one that fixesdthe issue linked above, to https://github.com/VirtusLab/scala-packager |
2683236 to
65ab599
Compare
MaciejG604
approved these changes
Nov 27, 2023
modules/integration/src/test/scala/scala/cli/integration/NativePackagerTests.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so here's some context.
We've been running our
macOStests onmacOS-12(not to confuse withmacOS-m1tests, which use a self-hosted runner)It seems the
macOS-12has become very flaky between the15.11.2023and29.10.2023versions.As GitHub runners only guarantee the major versions of the image running on the runner node, it seems there's 2 kinds of nodes in the flock:
macOS-12/20231029.1<- this runs our CI fine with MacOS 12.6.9, version from29.10.2023(older)macOS-12/20241115.2<- this fails a couple of our tests with invalidlibsodiumjni, macOS 12.7.1, version from15.11.2023(seems to be the latestmacOS-12)https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
macOS-13seems to be tagged as a beta release as of the time of this PR, but I suspect it should get promoted to stable soon.For the purposes of our CI, it seems to be a lot more stable than
macOS-12.The flakiness detected in this PR (electron-userland/electron-builder#7137, as noted by @MaciejG604) actually happens on
macos-12as well.TL;DR bumping to
macOS-13seems to be the way to go, even though it's still considered to be in beta.