Skip to content

Bump MacOS CI to macOS-13 #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Limit flaky test tagging to non-M1 Macs
  • Loading branch information
Gedochao committed Nov 27, 2023
commit 65ab599c976c25f9a5b5b3cd5a001292bf2eed30
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,7 @@ class NativePackagerTests extends ScalaCliSuite {
}
}
}

// building dmg package sometimes fails with:
// 'hdiutil: couldn't eject "disk2" - Resource busy'
test("building dmg package".flaky) {

def testBuildingDmgPackage(): Unit =
testInputs.fromRoot { root =>

val appName = helloWorldFileName.stripSuffix(".scala").toLowerCase()
Expand Down Expand Up @@ -109,6 +105,15 @@ class NativePackagerTests extends ScalaCliSuite {
)
}
}

// FIXME: building dmg package sometimes fails with:
// 'hdiutil: couldn't eject "disk2" - Resource busy'
if (TestUtil.isM1 || !TestUtil.isCI)
test("building dmg package") {
testBuildingDmgPackage()
}
else test("building dmg package".flaky) {
testBuildingDmgPackage()
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ object TestUtil {
val isNativeCli: Boolean = cliKind.startsWith("native")
val isJvmCli: Boolean = cliKind.startsWith("jvm")
val isCI: Boolean = System.getenv("CI") != null
val isM1: Boolean = sys.props.get("os.arch").contains("aarch64")
val cliPath: String = sys.props("test.scala-cli.path")
val debugPortOpt: Option[String] = sys.props.get("test.scala-cli.debug.port")
val detectCliPath = if (TestUtil.isNativeCli) TestUtil.cliPath else "scala-cli"
Expand Down