[#106341] [Ruby master Bug#18369] users.detect(:name, "Dorian") as shorthand for users.detect { |user| user.name == "Dorian" } — dorianmariefr <noreply@...>
Issue #18369 has been reported by dorianmariefr (Dorian Mari辿).
14 messages
2021/11/30
[#106351] [Ruby master Bug#18371] Release branches (release information in general) — "tenderlovemaking (Aaron Patterson)" <noreply@...>
Issue #18371 has been reported by tenderlovemaking (Aaron Patterson).
7 messages
2021/11/30
[ruby-core:106212] [Ruby master Bug#18356] Please replace use of unsafe MD5 with another digest algorithm
From:
"pvalena (Pavel Valena)" <noreply@...>
Date:
2021-11-22 17:23:22 UTC
List:
ruby-core #106212
Issue #18356 has been updated by pvalena (Pavel Valena).
byroot (Jean Boussier) wrote in #note-2:
> This is all from bundler / rubygems, so I believe we should close as a third party issue.
Please note that was a filtered list, there are other dependecies, such as `pop3`/`imap`, `cgi`, and other `net/` uses.
On the tests side - a test is failing on
```
/builddir/build/BUILD/ruby-3.0.2/test/net/http/test_buffered_io.rb: cannot load such file -- digest/md5
```
(There might be more issues as well, I'm still investigating.)
Also, there's md5 implementation in `ext/digest/md5/`. Could the tests be adjusted not to fail on md5 absence?
----------------------------------------
Bug #18356: Please replace use of unsafe MD5 with another digest algorithm
https://bugs.ruby-lang.org/issues/18356#change-94821
* Author: pvalena (Pavel Valena)
* Status: Open
* Priority: Normal
* Backport: 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN
----------------------------------------
Similarly to https://bugs.ruby-lang.org/issues/18272
## Context
When working on a new version of RHEL (with Ruby 3.0), the requirement is to have a better security (remove unsafe digests or limit the use for non-security purposes). This would be achieved with using OpenSSL 3.0 as well, which will have a raised security level by default, forbidding the use of unsafe digests.
## Issue
MD5 does not conform to the security requirements, and its replacement would be preferred.
Currently, the following files indicate it's use:
```
rubygems/package.rb: return super unless gem.start.include? 'MD5SUM ='
bundler/compact_index_client/cache.rb: name += "-#{SharedHelpers.digest(:MD5).hexdigest(name).downcase}"
bundler/compact_index_client/updater.rb: SharedHelpers.digest(:MD5).hexdigest(File.read(path))
bundler/source/rubygems/remote.rb: uri_digest = SharedHelpers.digest(:MD5).hexdigest(uri_parts.compact.join("."))
bundler/vendor/thor/lib/thor/runner.rb: :filename => Digest::MD5.hexdigest(name + as),
```
## Alternative solution
The use for non-security purposes might be indicated with setting an internal variable (when using OpenSSL implementation), which would allow the use of MD5 (although forbidden via OpenSSL setting). Do you think this would be possible?
## Question
AFAICT in Ruby it is used for non-security purposes only. Could you confirm that?
## Additional information
The tests failed on `digests/md5` removal:
https://gist.github.com/pvalena/ce6af993c6fe7c825cc41be81e1944ad
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:[email protected]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>