pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 1 | // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "components/ntp_snippets/content_suggestions_service.h" |
| 6 | |
| 7 | #include <algorithm> |
| 8 | #include <iterator> |
vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 9 | #include <set> |
jkrcal | e13510e | 2016-09-08 17:56:20 | [diff] [blame] | 10 | #include <utility> |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 11 | |
| 12 | #include "base/bind.h" |
pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 13 | #include "base/location.h" |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 14 | #include "base/strings/string_number_conversions.h" |
pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 15 | #include "base/threading/thread_task_runner_handle.h" |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 16 | #include "ui/gfx/image/image.h" |
| 17 | |
| 18 | namespace ntp_snippets { |
| 19 | |
vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 20 | ContentSuggestionsService::ContentSuggestionsService( |
| 21 | State state, |
jkrcal | e13510e | 2016-09-08 17:56:20 | [diff] [blame] | 22 | history::HistoryService* history_service, |
| 23 | PrefService* pref_service) |
| 24 | : state_(state), |
| 25 | history_service_observer_(this), |
treib | fd0db3c | 2016-09-20 12:22:15 | [diff] [blame^] | 26 | ntp_snippets_service_(nullptr), |
jkrcal | e13510e | 2016-09-08 17:56:20 | [diff] [blame] | 27 | user_classifier_(pref_service) { |
vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 28 | // Can be null in tests. |
| 29 | if (history_service) |
| 30 | history_service_observer_.Add(history_service); |
| 31 | } |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 32 | |
| 33 | ContentSuggestionsService::~ContentSuggestionsService() {} |
| 34 | |
| 35 | void ContentSuggestionsService::Shutdown() { |
pke | 5728f08 | 2016-08-03 17:27:35 | [diff] [blame] | 36 | ntp_snippets_service_ = nullptr; |
| 37 | id_category_map_.clear(); |
| 38 | suggestions_by_category_.clear(); |
| 39 | providers_by_category_.clear(); |
| 40 | categories_.clear(); |
| 41 | providers_.clear(); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 42 | state_ = State::DISABLED; |
| 43 | FOR_EACH_OBSERVER(Observer, observers_, ContentSuggestionsServiceShutdown()); |
| 44 | } |
| 45 | |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 46 | CategoryStatus ContentSuggestionsService::GetCategoryStatus( |
| 47 | Category category) const { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 48 | if (state_ == State::DISABLED) { |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 49 | return CategoryStatus::ALL_SUGGESTIONS_EXPLICITLY_DISABLED; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 50 | } |
| 51 | |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 52 | auto iterator = providers_by_category_.find(category); |
| 53 | if (iterator == providers_by_category_.end()) |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 54 | return CategoryStatus::NOT_PROVIDED; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 55 | |
| 56 | return iterator->second->GetCategoryStatus(category); |
| 57 | } |
| 58 | |
pke | bd2f650a | 2016-08-09 14:53:45 | [diff] [blame] | 59 | base::Optional<CategoryInfo> ContentSuggestionsService::GetCategoryInfo( |
| 60 | Category category) const { |
| 61 | auto iterator = providers_by_category_.find(category); |
| 62 | if (iterator == providers_by_category_.end()) |
| 63 | return base::Optional<CategoryInfo>(); |
| 64 | return iterator->second->GetCategoryInfo(category); |
| 65 | } |
| 66 | |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 67 | const std::vector<ContentSuggestion>& |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 68 | ContentSuggestionsService::GetSuggestionsForCategory(Category category) const { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 69 | auto iterator = suggestions_by_category_.find(category); |
| 70 | if (iterator == suggestions_by_category_.end()) |
| 71 | return no_suggestions_; |
| 72 | return iterator->second; |
| 73 | } |
| 74 | |
| 75 | void ContentSuggestionsService::FetchSuggestionImage( |
| 76 | const std::string& suggestion_id, |
| 77 | const ImageFetchedCallback& callback) { |
| 78 | if (!id_category_map_.count(suggestion_id)) { |
| 79 | LOG(WARNING) << "Requested image for unknown suggestion " << suggestion_id; |
pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 80 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
pke | f29505d | 2016-08-26 14:46:34 | [diff] [blame] | 81 | FROM_HERE, base::Bind(callback, gfx::Image())); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 82 | return; |
| 83 | } |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 84 | Category category = id_category_map_.at(suggestion_id); |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 85 | if (!providers_by_category_.count(category)) { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 86 | LOG(WARNING) << "Requested image for suggestion " << suggestion_id |
pke | 31b0794 | 2016-08-01 11:35:02 | [diff] [blame] | 87 | << " for unavailable category " << category; |
pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 88 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
pke | f29505d | 2016-08-26 14:46:34 | [diff] [blame] | 89 | FROM_HERE, base::Bind(callback, gfx::Image())); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 90 | return; |
| 91 | } |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 92 | providers_by_category_[category]->FetchSuggestionImage(suggestion_id, |
| 93 | callback); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 94 | } |
| 95 | |
vitaliii | 685fdfaa | 2016-08-31 11:25:46 | [diff] [blame] | 96 | void ContentSuggestionsService::ClearHistory( |
| 97 | base::Time begin, |
| 98 | base::Time end, |
| 99 | const base::Callback<bool(const GURL& url)>& filter) { |
| 100 | for (const auto& provider : providers_) { |
| 101 | provider->ClearHistory(begin, end, filter); |
| 102 | } |
| 103 | } |
| 104 | |
treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 105 | void ContentSuggestionsService::ClearAllCachedSuggestions() { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 106 | suggestions_by_category_.clear(); |
| 107 | id_category_map_.clear(); |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 108 | for (const auto& category_provider_pair : providers_by_category_) { |
treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 109 | category_provider_pair.second->ClearCachedSuggestions( |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 110 | category_provider_pair.first); |
pke | 222d8a5 | 2016-08-10 12:37:52 | [diff] [blame] | 111 | FOR_EACH_OBSERVER(Observer, observers_, |
| 112 | OnNewSuggestions(category_provider_pair.first)); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 113 | } |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 114 | } |
| 115 | |
treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 116 | void ContentSuggestionsService::ClearCachedSuggestions( |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 117 | Category category) { |
| 118 | for (const ContentSuggestion& suggestion : |
| 119 | suggestions_by_category_[category]) { |
| 120 | id_category_map_.erase(suggestion.id()); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 121 | } |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 122 | suggestions_by_category_[category].clear(); |
| 123 | auto iterator = providers_by_category_.find(category); |
| 124 | if (iterator != providers_by_category_.end()) |
treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 125 | iterator->second->ClearCachedSuggestions(category); |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 126 | } |
| 127 | |
pke | de0dd9f | 2016-08-23 09:18:11 | [diff] [blame] | 128 | void ContentSuggestionsService::GetDismissedSuggestionsForDebugging( |
| 129 | Category category, |
| 130 | const DismissedSuggestionsCallback& callback) { |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 131 | auto iterator = providers_by_category_.find(category); |
pke | de0dd9f | 2016-08-23 09:18:11 | [diff] [blame] | 132 | if (iterator != providers_by_category_.end()) |
| 133 | iterator->second->GetDismissedSuggestionsForDebugging(category, callback); |
| 134 | else |
| 135 | callback.Run(std::vector<ContentSuggestion>()); |
pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 136 | } |
| 137 | |
| 138 | void ContentSuggestionsService::ClearDismissedSuggestionsForDebugging( |
| 139 | Category category) { |
| 140 | auto iterator = providers_by_category_.find(category); |
| 141 | if (iterator != providers_by_category_.end()) |
| 142 | iterator->second->ClearDismissedSuggestionsForDebugging(category); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 143 | } |
| 144 | |
pke | 2646c95b | 2016-07-25 12:18:44 | [diff] [blame] | 145 | void ContentSuggestionsService::DismissSuggestion( |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 146 | const std::string& suggestion_id) { |
| 147 | if (!id_category_map_.count(suggestion_id)) { |
pke | 2646c95b | 2016-07-25 12:18:44 | [diff] [blame] | 148 | LOG(WARNING) << "Dismissed unknown suggestion " << suggestion_id; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 149 | return; |
| 150 | } |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 151 | Category category = id_category_map_.at(suggestion_id); |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 152 | if (!providers_by_category_.count(category)) { |
pke | 2646c95b | 2016-07-25 12:18:44 | [diff] [blame] | 153 | LOG(WARNING) << "Dismissed suggestion " << suggestion_id |
pke | 31b0794 | 2016-08-01 11:35:02 | [diff] [blame] | 154 | << " for unavailable category " << category; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 155 | return; |
| 156 | } |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 157 | providers_by_category_[category]->DismissSuggestion(suggestion_id); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 158 | |
| 159 | // Remove the suggestion locally. |
pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 160 | bool removed = RemoveSuggestionByID(category, suggestion_id); |
| 161 | DCHECK(removed) << "The dismissed suggestion " << suggestion_id |
| 162 | << " has already been removed. Providers must not call" |
| 163 | << " OnNewSuggestions in response to DismissSuggestion."; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 164 | } |
| 165 | |
dgn | 212feea3b | 2016-09-16 15:08:20 | [diff] [blame] | 166 | void ContentSuggestionsService::DismissCategory(Category category) { |
| 167 | auto providers_it = providers_by_category_.find(category); |
| 168 | if (providers_it == providers_by_category_.end()) |
| 169 | return; |
| 170 | |
| 171 | providers_by_category_.erase(providers_it); |
| 172 | categories_.erase( |
| 173 | std::find(categories_.begin(), categories_.end(), category)); |
| 174 | } |
| 175 | |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 176 | void ContentSuggestionsService::AddObserver(Observer* observer) { |
| 177 | observers_.AddObserver(observer); |
| 178 | } |
| 179 | |
| 180 | void ContentSuggestionsService::RemoveObserver(Observer* observer) { |
| 181 | observers_.RemoveObserver(observer); |
| 182 | } |
| 183 | |
| 184 | void ContentSuggestionsService::RegisterProvider( |
pke | 5728f08 | 2016-08-03 17:27:35 | [diff] [blame] | 185 | std::unique_ptr<ContentSuggestionsProvider> provider) { |
| 186 | DCHECK(state_ == State::ENABLED); |
pke | 5728f08 | 2016-08-03 17:27:35 | [diff] [blame] | 187 | providers_.push_back(std::move(provider)); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 188 | } |
| 189 | |
| 190 | //////////////////////////////////////////////////////////////////////////////// |
| 191 | // Private methods |
| 192 | |
| 193 | void ContentSuggestionsService::OnNewSuggestions( |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 194 | ContentSuggestionsProvider* provider, |
| 195 | Category category, |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 196 | std::vector<ContentSuggestion> new_suggestions) { |
pke | 3b2e363 | 2016-08-12 12:52:53 | [diff] [blame] | 197 | if (RegisterCategoryIfRequired(provider, category)) |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 198 | NotifyCategoryStatusChanged(category); |
pke | 3b2e363 | 2016-08-12 12:52:53 | [diff] [blame] | 199 | |
| 200 | if (!IsCategoryStatusAvailable(provider->GetCategoryStatus(category))) |
| 201 | return; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 202 | |
| 203 | for (const ContentSuggestion& suggestion : |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 204 | suggestions_by_category_[category]) { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 205 | id_category_map_.erase(suggestion.id()); |
| 206 | } |
| 207 | |
pke | 3b2e363 | 2016-08-12 12:52:53 | [diff] [blame] | 208 | for (const ContentSuggestion& suggestion : new_suggestions) |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 209 | id_category_map_.insert(std::make_pair(suggestion.id(), category)); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 210 | |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 211 | suggestions_by_category_[category] = std::move(new_suggestions); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 212 | |
treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 213 | // The positioning of the bookmarks category depends on whether it's empty. |
| 214 | // TODO(treib): Remove this temporary hack, crbug.com/640568. |
| 215 | if (category.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 216 | SortCategories(); |
| 217 | |
pke | 222d8a5 | 2016-08-10 12:37:52 | [diff] [blame] | 218 | FOR_EACH_OBSERVER(Observer, observers_, OnNewSuggestions(category)); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 219 | } |
| 220 | |
| 221 | void ContentSuggestionsService::OnCategoryStatusChanged( |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 222 | ContentSuggestionsProvider* provider, |
| 223 | Category category, |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 224 | CategoryStatus new_status) { |
| 225 | if (!IsCategoryStatusAvailable(new_status)) { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 226 | for (const ContentSuggestion& suggestion : |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 227 | suggestions_by_category_[category]) { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 228 | id_category_map_.erase(suggestion.id()); |
| 229 | } |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 230 | suggestions_by_category_.erase(category); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 231 | } |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 232 | if (new_status == CategoryStatus::NOT_PROVIDED) { |
dgn | 212feea3b | 2016-09-16 15:08:20 | [diff] [blame] | 233 | DCHECK(providers_by_category_.find(category) != |
| 234 | providers_by_category_.end()); |
| 235 | DCHECK_EQ(provider, providers_by_category_.find(category)->second); |
| 236 | DismissCategory(category); |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 237 | } else { |
| 238 | RegisterCategoryIfRequired(provider, category); |
| 239 | DCHECK_EQ(new_status, provider->GetCategoryStatus(category)); |
| 240 | } |
| 241 | NotifyCategoryStatusChanged(category); |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 242 | } |
| 243 | |
pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 244 | void ContentSuggestionsService::OnSuggestionInvalidated( |
| 245 | ContentSuggestionsProvider* provider, |
| 246 | Category category, |
| 247 | const std::string& suggestion_id) { |
| 248 | RemoveSuggestionByID(category, suggestion_id); |
| 249 | FOR_EACH_OBSERVER(Observer, observers_, |
| 250 | OnSuggestionInvalidated(category, suggestion_id)); |
| 251 | } |
| 252 | |
vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 253 | // history::HistoryServiceObserver implementation. |
| 254 | void ContentSuggestionsService::OnURLsDeleted( |
| 255 | history::HistoryService* history_service, |
| 256 | bool all_history, |
| 257 | bool expired, |
| 258 | const history::URLRows& deleted_rows, |
| 259 | const std::set<GURL>& favicon_urls) { |
| 260 | // We don't care about expired entries. |
| 261 | if (expired) |
| 262 | return; |
| 263 | |
| 264 | // Redirect to ClearHistory(). |
| 265 | if (all_history) { |
| 266 | base::Time begin = base::Time(); |
| 267 | base::Time end = base::Time::Max(); |
| 268 | base::Callback<bool(const GURL& url)> filter = |
| 269 | base::Bind([](const GURL& url) { return true; }); |
| 270 | ClearHistory(begin, end, filter); |
| 271 | } else { |
| 272 | if (deleted_rows.empty()) |
| 273 | return; |
| 274 | |
| 275 | base::Time begin = deleted_rows[0].last_visit(); |
| 276 | base::Time end = deleted_rows[0].last_visit(); |
| 277 | std::set<GURL> deleted_urls; |
| 278 | for (const history::URLRow& row : deleted_rows) { |
| 279 | if (row.last_visit() < begin) |
| 280 | begin = row.last_visit(); |
| 281 | if (row.last_visit() > end) |
| 282 | end = row.last_visit(); |
| 283 | deleted_urls.insert(row.url()); |
| 284 | } |
| 285 | base::Callback<bool(const GURL& url)> filter = base::Bind( |
| 286 | [](const std::set<GURL>& set, const GURL& url) { |
| 287 | return set.count(url) != 0; |
| 288 | }, |
| 289 | deleted_urls); |
| 290 | ClearHistory(begin, end, filter); |
| 291 | } |
| 292 | } |
| 293 | |
| 294 | void ContentSuggestionsService::HistoryServiceBeingDeleted( |
| 295 | history::HistoryService* history_service) { |
| 296 | history_service_observer_.RemoveAll(); |
| 297 | } |
| 298 | |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 299 | bool ContentSuggestionsService::RegisterCategoryIfRequired( |
| 300 | ContentSuggestionsProvider* provider, |
| 301 | Category category) { |
| 302 | auto it = providers_by_category_.find(category); |
| 303 | if (it != providers_by_category_.end()) { |
| 304 | DCHECK_EQ(it->second, provider); |
| 305 | return false; |
| 306 | } |
| 307 | |
| 308 | providers_by_category_[category] = provider; |
| 309 | categories_.push_back(category); |
treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 310 | SortCategories(); |
pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 311 | if (IsCategoryStatusAvailable(provider->GetCategoryStatus(category))) { |
| 312 | suggestions_by_category_.insert( |
| 313 | std::make_pair(category, std::vector<ContentSuggestion>())); |
| 314 | } |
| 315 | return true; |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 316 | } |
| 317 | |
pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 318 | bool ContentSuggestionsService::RemoveSuggestionByID( |
| 319 | Category category, |
| 320 | const std::string& suggestion_id) { |
| 321 | id_category_map_.erase(suggestion_id); |
| 322 | std::vector<ContentSuggestion>* suggestions = |
| 323 | &suggestions_by_category_[category]; |
| 324 | auto position = |
| 325 | std::find_if(suggestions->begin(), suggestions->end(), |
| 326 | [&suggestion_id](const ContentSuggestion& suggestion) { |
| 327 | return suggestion_id == suggestion.id(); |
| 328 | }); |
| 329 | if (position == suggestions->end()) |
| 330 | return false; |
| 331 | suggestions->erase(position); |
treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 332 | |
| 333 | // The positioning of the bookmarks category depends on whether it's empty. |
| 334 | // TODO(treib): Remove this temporary hack, crbug.com/640568. |
| 335 | if (category.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 336 | SortCategories(); |
| 337 | |
pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 338 | return true; |
| 339 | } |
| 340 | |
pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 341 | void ContentSuggestionsService::NotifyCategoryStatusChanged(Category category) { |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 342 | FOR_EACH_OBSERVER( |
| 343 | Observer, observers_, |
| 344 | OnCategoryStatusChanged(category, GetCategoryStatus(category))); |
| 345 | } |
| 346 | |
treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 347 | void ContentSuggestionsService::SortCategories() { |
| 348 | auto it = suggestions_by_category_.find( |
| 349 | category_factory_.FromKnownCategory(KnownCategories::BOOKMARKS)); |
| 350 | bool bookmarks_empty = |
| 351 | (it == suggestions_by_category_.end() || it->second.empty()); |
| 352 | std::sort( |
| 353 | categories_.begin(), categories_.end(), |
| 354 | [this, bookmarks_empty](const Category& left, const Category& right) { |
| 355 | // If the bookmarks section is empty, put it at the end. |
| 356 | // TODO(treib): This is a temporary hack, see crbug.com/640568. |
| 357 | if (bookmarks_empty) { |
| 358 | if (left.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 359 | return false; |
| 360 | if (right.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 361 | return true; |
| 362 | } |
| 363 | return category_factory_.CompareCategories(left, right); |
| 364 | }); |
| 365 | } |
| 366 | |
pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 367 | } // namespace ntp_snippets |